Replace Vue Redux with Pinia - #112
Open
crookedneighbor wants to merge 19 commits into
Open
Conversation
scarletcs
self-requested a review
May 3, 2025 18:43
scarletcs
reviewed
May 3, 2025
scarletcs
reviewed
May 3, 2025
crookedneighbor
changed the title
crookedneighbor
commented
May 9, 2025
crookedneighbor
commented
May 9, 2025
Comment on lines
+110
to
+134
| it("manages card state for successful queries", async () => { | ||
| const game = useGameStore(); | ||
|
|
||
| vi.mocked(ScryfallApiInstance.getRandomArt).mockImplementation(() => { | ||
| return new Promise((resolve) => { | ||
| finishApiCall = resolve; | ||
| }); | ||
| }); | ||
| game.query = { search: "query" }; | ||
| game.card = CardBank.ArborElf; | ||
|
|
||
| const fetchPromise = game.fetchNextCard(); | ||
| await nextTick(); | ||
|
|
||
| expect(game.nextCardStatus).toEqual(LoadingStatus.Pending); | ||
| expect(game.previousCard).toEqual(CardBank.ArborElf); | ||
| expect(game.card).toEqual(CardBank.ArborElf); | ||
|
|
||
| finishApiCall(CardBank.Jolene); | ||
| await fetchPromise; | ||
|
|
||
| expect(game.nextCardStatus).toEqual(LoadingStatus.Success); | ||
| expect(game.previousCard).toEqual(CardBank.ArborElf); | ||
| expect(game.card).toEqual(CardBank.Jolene); | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
Don't love how this pattern of delaying the api response this way, but it was the best way I could figure out to assert on the state of the store before the api call finished. Open to suggestions though.
crookedneighbor
force-pushed
the
pinia-with-tests
branch
from
May 10, 2025 12:53
3b2098b to
914ba99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spike, so I only converted the config store, not the game store. If we like this approach, happy to convert over the game store as well. I've PR'd this into the add-testing-library branch so we can see more easily how much easier it is to work with this system as the store in the testing environment.
First time using pinia, overall, I like a ton better then the store we're currently using. I find it much easier to reason what's going on with it.
Functional changes:
"true"^ Users who are not messing with local storage should never see any difference