Feat - Add card clues to narrow down the card - #116
Conversation
| import CardArt from "./CardArt.vue"; | ||
| import GuessInput from "./GuessInput.vue"; | ||
| import { isGuessOk } from "../utils/guess"; | ||
| import CardArt from "./CardArt.vue"; |
There was a problem hiding this comment.
Hmm, maybe my linter is not set up correctly (I am using Cursor)
| set: string; | ||
| image_uris: ScryfallImageUris; | ||
| card_faces?: never; | ||
| cmc: number; |
There was a problem hiding this comment.
This is duplicated for now and I notice this exists https://github.com/scryfall/api-types, checking if this can be in another PR or in this one?
| align-items: stretch; | ||
| max-height: calc((var(--count) + 0.6) * (1em + var(--v-padding) * 2)); | ||
| overflow-y: scroll; | ||
| z-index: 10; |
There was a problem hiding this comment.
Fixes this issue, admittedly a bit haphazard since there is no z-indexes.ts yet, which we can add in this PR too.
daryllxd
changed the title
|
Hey! Didn't see this until just now. We're in the process of switching to a different store library (PR here) - once that's merged in, and this PR has been updated to use the new system, I can take a look at this PR. |
|
Since this PR opened, I've added a CONTRIBUTING.md file laying out our guidelines. While I've considered adding a hint system of some kind, we're not currently looking to add this hint system here. |
3 participants
Hello, I am a Magic player that has recently changed jobs and is looking to learn more Vue.js. I accidentally found this repo while I was looking to create some tools for Magic the Gathering and this is just my first PR to add clues because while I was testing the art game, I really couldn't figure out any of the cards but the clues kind of helped. I would like to have a few weeks until my new job starts so I can put in a few hours a day to contribute.
I can also pick one from the issues if it's fine
CleanShot.2025-05-20.at.22.58.52-converted.mp4