Skip to content

fix(DAN-873): CI must follow the code, not the base branch #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danny-Devs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(DAN-873): CI must follow the code, not the base branch #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,20 @@ name: CI
on:
push:
branches: [main]
# NO `branches:` filter here, deliberately (DAN-873).
#
# `pull_request.branches` filters on the PR's BASE branch. With `[main]`, a
# stacked PR — one opened against another PR's branch — matched nothing and
# ran ZERO jobs, while GitHub still rendered a green checks column from the
# Vercel deployment. Measured 2026-08-16:
#
# PR #7 base agent-a/DAN-855-… 0 CI jobs + 2 Vercel "green"
# PR #8 base main 8 CI jobs + 2 Vercel green
#
# Absence of a failing check is not the same as absence of checking, and the
# two are indistinguishable at a glance. Stacking is a normal way to work
# here, so the suite must follow the code rather than the base branch.
pull_request:
branches: [main]

permissions:
contents: read
Expand Down
Loading