fix(DAN-873): CI must follow the code, not the base branch - #9
Open
Danny-Devs wants to merge 1 commit into
Open
Conversation
pull_request.branches filters on the PR BASE. With [main], a stacked PR — one opened against another PR branch — matched nothing and ran ZERO jobs, while GitHub still rendered a green checks column from the Vercel deployment. Measured today, same repo, same hour: PR #7 base agent-a/DAN-855-... 0 CI jobs + 2 Vercel reads "green" PR #8 base main 8 CI jobs + 2 Vercel is green Absence of a failing check is not absence of checking, and at a glance the two are identical. Stacking is a normal way to work in this repo, so removing the filter is the fix; the push trigger keeps its [main] filter, which is correct.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DAN-873.
The defect
pull_request.branchesfilters on the pull request's base branch. Withbranches: [main], a stacked PR — one opened against another PR's branch — matches nothing and runs zero jobs. GitHub still renders a green checks column, because the Vercel deployment reports independently of the CI workflow.Measured in this repo today, within the same hour:
agent-a/DAN-855-…mainAbsence of a failing check is not absence of checking, and at a glance the two are identical. PR #7's eight jobs — Python 3.10/3.11/3.12/3.13, S7 Chain-Agnostic Boundary, TypeScript Node 20/22, TypeScript Build — never ran at all. They were run by hand instead, which is a person doing a machine's job.
The fix
Remove the
branchesfilter frompull_request. Thepushtrigger keeps[main], which is correct — push-CI on every branch would be duplicate work, since the PR event already covers it.Stacking is a normal way to work in this repo (#7 is stacked on #6 right now), so the suite has to follow the code rather than the base branch.
Verification
The definitive proof is a stacked PR running the full suite after this lands — that cannot be observed from this PR, and I am not claiming it has been. What is established is the diagnosis, from the measurement above: the only difference between #7 and #8 is the base branch, and the only construct keying on the base branch is the line this PR deletes.
This PR targets
main, so its own checks run.🤖 Generated with Claude Code