Skip to content

cargotest: replace Servo with standalone Stylo #160556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HNO3Miracle wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −11
Open

cargotest: replace Servo with standalone Stylo #160556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb80c17
cargotest: replace Servo with Stylo
HNO3Miracle Aug 5, 2026
198d797
cargotest: test Stylo after upstream fix
HNO3Miracle Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/doc/rustc-dev-guide/src/tests/ecosystem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ CI. See the [Crater chapter](crater.md) for more details.
### `cargotest`

`cargotest` is a small tool which runs `cargo test` on a few sample projects
(such as `servo`, `ripgrep`, `tokei`, etc.). This runs as part of CI and ensures
(such as `stylo`, `ripgrep`, `tokei`, etc.). This runs as part of CI and ensures
there aren't any significant regressions:

```console
Expand Down
14 changes: 4 additions & 10 deletions src/tools/cargotest/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,11 @@ const TEST_REPOS: &[Test] = &[
],
},
Test {
name: "servo",
repo: "https://github.com/servo/servo",
sha: "785a344e32db58d4e631fd3cae17fd1f29a721ab",
name: "stylo",
repo: "https://github.com/servo/stylo",
sha: "127b0b5cab6a6927552e889debb20beb031b79d1",
lock: None,
// Only test Stylo a.k.a. Quantum CSS, the parts of Servo going into Firefox.
// This takes much less time to build than all of Servo and supports stable Rust.
packages: &["selectors"],
packages: &["selectors", "stylo"],
features: None,
manifest_path: None,
filters: &[],
Expand Down Expand Up @@ -213,10 +211,6 @@ fn run_cargo_test(
.env("CFG_DISABLE_CROSS_TESTS", "1")
// Relax #![deny(warnings)] in some crates
.env("RUSTFLAGS", "--cap-lints warn")
// servo tries to use 'lld-link.exe' on windows, but we don't
// have lld on our PATH in CI. Override it to use 'link.exe'
.env("CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_LINKER", "link.exe")
.env("CARGO_TARGET_I686_PC_WINDOWS_MSVC_LINKER", "link.exe")
.current_dir(crate_path)
.status()
.unwrap();
Expand Down
Loading