cargotest: replace Servo with standalone Stylo - #160556
Conversation
Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
|
|
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
What's the problem? Is this something we can address? |
Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
|
This was tracked in servo/stylo#308. The shared tests used Gecko pseudo-elements such as Coincidentally, this was fixed upstream yesterday by servo/stylo#436, which also enabled I have updated this PR to use the resulting revision ( |
The Servo entry in
cargotestpins a 2019 checkout and only tests theselectorspackage. Cargo still has to resolve the old Servo workspace,including its large graph of Git dependencies, even though most of that
workspace is not covered by the test.
Both
selectorsand thestyloCSS engine now live in the standaloneservo/stylorepository. This PR replacesthe old Servo checkout with a recent Stylo revision and runs both
cargo test -p selectorsandcargo test -p stylofrom the same checkout.Stylo's unit tests previously failed under the default Servo configuration
because shared tests used pseudo-elements that were only available in Gecko.
This was fixed in
servo/stylo#436,and this PR pins the resulting revision.
The
cargotestdocumentation is updated to list Stylo instead of Servo.Tests:
cargo test --manifest-path src/tools/cargotest/Cargo.tomltarget/debug/cargotest "$(command -v cargo)" /tmp/cargotest-stylo stylo./x test tidy --set build.submodules=falseCloses #79404.