Refactor out common code into a `IndexItem::new` constructor by yotamofek · Pull Request #149452 · rust-lang/rust

yotamofek · 2025-11-29T12:56:57Z

yotamofek · 2025-11-29T12:59:31Z

@lolbinarycat Felt like doing something semi-mechanical that doesn't require too much concentration, so thought I'd tackle the issue you opened.

But TBH, after pulling out the common code into an IndexItem constructor, I'm not sure it makes much sense and/or is worth it.
What do you think?

lolbinarycat · 2025-11-29T18:23:09Z

It was working on #149460 that inspired this issue, and I agree that perhaps a substruct would be a better approach.

yotamofek · 2025-12-12T23:36:00Z

What do you think about how it looks now? @lolbinarycat
(still need to find a better name for the "sub struct")

yotamofek · 2025-12-12T23:36:20Z

the amount of times I typed "sub stract" instead of "sub struct"....... 😤

lolbinarycat · 2025-12-14T18:04:53Z

IndexItemInfo maybe? then the field could just be named info

rustbot · 2025-12-15T20:27:11Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

yotamofek · 2025-12-15T20:27:39Z

Well, done, not sure it's an improvement, but let's see what others think.

GuillaumeGomez · 2025-12-16T14:11:32Z

Changes look good to me. So if it's ok with lolbinarycat and notriddle, you can r=us.

lolbinarycat · 2026-01-28T17:26:26Z

Will need to be rebased on top of #149460 once that is merged.

Enselic · 2026-04-17T17:06:49Z

Triage: This seems close to having been merged. @lolbinarycat @notriddle Are you OK with r=GuillaumeGomez
after this has been rebased?

lolbinarycat · 2026-04-17T20:05:18Z

I would like to actually see the rebased code, as I believe it would not be entirely trivial, but I am still on board with this change.

notriddle · 2026-04-18T02:26:40Z

@lolbinarycat I agree. This looks like a good change, overall, and just needs rebased.

rustbot · 2026-04-18T19:23:11Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

yotamofek · 2026-04-18T19:26:11Z

Here we go!
Not sure how much sense this makes after rebase, but I've lost context in the couple of months since I touched this PR, so leaving the call to fresh-er eyes.

(also, wasn't really around for the past two months or so, so - hey everyone :))

notriddle · 2026-04-19T20:30:18Z

-    let is_deprecated = item.is_deprecated(tcx);
-    let is_unstable = item.is_unstable();
    let index_item = IndexItem {
        ty: item.type_(),


Why isn't ty: item.type_() a member of IndexItemInfo. It's common code shared between both spots where IndexItem is constructed, but it isn't factored out.

View changes since the review

Missed that, thanks!

notriddle · 2026-04-24T15:56:54Z

@bors r=notriddle,lolbinarycat

rust-bors · 2026-04-24T15:56:56Z

📌 Commit ab1500b has been approved by notriddle,lolbinarycat

It is now in the queue for this repository.

…uwer Rollup of 12 pull requests Successful merges: - #149452 (Refactor out common code into a `IndexItem::new` constructor) - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155635 (delegation: rename `Self` generic param to `This` in recursive delegations) - #155730 (Some cleanups around per parent disambiguators) - #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu) - #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations) - #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer) - #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf) - #155713 (test: Add a regression test for Apple platforms aborting on `free`) - #155723 (Fix tier level for 5 thumb bare-metal ARM targets) - #155735 (Fix typo by removing extra 'to') - #155736 (Remove `AllVariants` workaround for rust-analyzer)

rust-bors · 2026-04-24T17:19:07Z

⌛ Testing commit ab1500b with merge 1790f3a...

Workflow: https://github.com/rust-lang/rust/actions/runs/24902498468

…le,lolbinarycat Refactor out common code into a `IndexItem::new` constructor #149404

JonathanBrouwer · 2026-04-24T17:30:21Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-04-24T17:30:25Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/24902498468

The next pull request likely to be tested is #155745.

…uwer Rollup of 12 pull requests Successful merges: - #149452 (Refactor out common code into a `IndexItem::new` constructor) - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155635 (delegation: rename `Self` generic param to `This` in recursive delegations) - #155730 (Some cleanups around per parent disambiguators) - #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu) - #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations) - #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer) - #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf) - #155713 (test: Add a regression test for Apple platforms aborting on `free`) - #155723 (Fix tier level for 5 thumb bare-metal ARM targets) - #155735 (Fix typo by removing extra 'to') - #155736 (Remove `AllVariants` workaround for rust-analyzer)

Rollup merge of #149452 - yotamofek:pr/rustdoc/IndexItem-new, r=notriddle,lolbinarycat Refactor out common code into a `IndexItem::new` constructor #149404

yotamofek requested a review from lolbinarycat November 29, 2025 12:57

This comment has been minimized.

Sign in to view

yotamofek force-pushed the pr/rustdoc/IndexItem-new branch 2 times, most recently from 32d0484 to 6cedf2c Compare November 29, 2025 17:13

yotamofek commented Nov 29, 2025

View reviewed changes

Comment thread src/librustdoc/html/render/mod.rs

This comment has been minimized.

Sign in to view

yotamofek force-pushed the pr/rustdoc/IndexItem-new branch from 6cedf2c to acd4d7e Compare December 12, 2025 22:32

yotamofek force-pushed the pr/rustdoc/IndexItem-new branch from a39f59d to 86a2e85 Compare December 15, 2025 20:26

yotamofek marked this pull request as ready for review December 15, 2025 20:27

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2025

rustbot assigned GuillaumeGomez Dec 15, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 15, 2025

GuillaumeGomez approved these changes Dec 16, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

yotamofek force-pushed the pr/rustdoc/IndexItem-new branch from 86a2e85 to 0cb2e2f Compare April 18, 2026 19:23

This comment has been minimized.

Sign in to view

yotamofek force-pushed the pr/rustdoc/IndexItem-new branch from 0cb2e2f to a6c2f86 Compare April 19, 2026 06:56

lolbinarycat approved these changes Apr 19, 2026

View reviewed changes

notriddle reviewed Apr 19, 2026

View reviewed changes

Separate out some IndexItem fields into a new struct and DRY

ab1500b

yotamofek force-pushed the pr/rustdoc/IndexItem-new branch from a6c2f86 to ab1500b Compare April 22, 2026 20:49

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026

JonathanBrouwer mentioned this pull request Apr 24, 2026

Rollup of 12 pull requests #155745

Merged

rust-bors Bot pushed a commit that referenced this pull request Apr 24, 2026

Auto merge of #149452 - yotamofek:pr/rustdoc/IndexItem-new, r=notridd…

1790f3a

…le,lolbinarycat Refactor out common code into a `IndexItem::new` constructor #149404

rust-bors Bot merged commit d4a700a into rust-lang:main Apr 24, 2026
11 of 12 checks passed

rustbot added this to the 1.97.0 milestone Apr 24, 2026

rust-timer added a commit that referenced this pull request Apr 24, 2026

Unrolled build for #149452

dd6669a

Rollup merge of #149452 - yotamofek:pr/rustdoc/IndexItem-new, r=notriddle,lolbinarycat Refactor out common code into a `IndexItem::new` constructor #149404

Uh oh!

Conversation

yotamofek commented Nov 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yotamofek commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

lolbinarycat commented Nov 29, 2025

Uh oh!

yotamofek commented Dec 12, 2025

Uh oh!

yotamofek commented Dec 12, 2025

Uh oh!

lolbinarycat commented Dec 14, 2025

Uh oh!

rustbot commented Dec 15, 2025

Uh oh!

yotamofek commented Dec 15, 2025

Uh oh!

GuillaumeGomez commented Dec 16, 2025

Uh oh!

This comment has been minimized.

lolbinarycat commented Jan 28, 2026

Uh oh!

Enselic commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lolbinarycat commented Apr 17, 2026

Uh oh!

notriddle commented Apr 18, 2026

Uh oh!

rustbot commented Apr 18, 2026

Uh oh!

yotamofek commented Apr 18, 2026

Uh oh!

This comment has been minimized.

notriddle Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yotamofek Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

notriddle commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yotamofek commented Nov 29, 2025 •

edited by rustbot

Loading

yotamofek commented Nov 29, 2025 •

edited

Loading

Enselic commented Apr 17, 2026 •

edited

Loading

notriddle Apr 19, 2026 •

edited

Loading

rust-bors Bot commented Apr 24, 2026 •

edited

Loading