Repository navigation
Move to rtcamp/wp-primitives - #782
Merged
Merged
Conversation
- restore truthful composer.lock where the rename had falsified it - correct unresolvable ^1.0 constraints in install docs - document the HANDLE_PREFIX and text-domain breaks - add the 1.0.x to 2.0.0 migration guide - prune the superseded instructions file on sync
Merged
aryanjasala
marked this pull request as ready for review
October 1, 2026 17:02
aryanjasala
requested review from
AnuragVasanwala
and
a balanced review from Copilot
October 1, 2026 17:02
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The dependency remains uninstallable until v2.0.0 is tagged and the lockfile and generated graph are fully refreshed.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Migrates the theme’s shared PHP foundation from rtcamp/wp-framework to rtcamp/wp-primitives.
Changes:
- Updates Composer dependency and PHP namespaces.
- Revises tests, documentation, prompts, and AI instructions.
- Partially updates the generated knowledge graph.
| File | Description |
|---|---|
composer.json |
Switches package repository and constraint. |
inc/Main.php |
Updates framework trait namespace. |
inc/Abstracts/AbstractThemeFeature.php |
Updates abstract and utility imports. |
inc/Core/Assets.php |
Updates asset contracts and loader imports. |
inc/Core/Components.php |
Updates component loader imports. |
inc/Core/Encryption.php |
Updates encryption imports. |
inc/Core/FeatureRegistry.php |
Updates feature utility imports. |
inc/Core/Logger.php |
Updates logger imports. |
inc/Core/Menu.php |
Updates registration contract import. |
inc/Core/Templates.php |
Updates template loader imports. |
inc/Core/ThemeSetup.php |
Updates registration contract import. |
inc/Modules/Settings/FeaturesSettingsPage.php |
Updates settings utility import. |
inc/Modules/Settings/ThemeOptions.php |
Updates settings abstract import. |
tests/php/inc/Core/AssetsTest.php |
Updates contract assertion namespace. |
tests/php/inc/Core/EncryptionTest.php |
Updates encryptor import. |
tests/php/inc/Core/FeaturesTest.php |
Updates feature imports. |
tests/php/inc/Core/LoggerTest.php |
Updates logger imports. |
tests/php/inc/Core/MenuTest.php |
Updates contract assertion namespace. |
tests/php/inc/Core/TemplatesTest.php |
Updates framework assertions. |
tests/php/inc/Core/ThemeSetupTest.php |
Updates contract assertion namespace. |
tests/php/inc/Modules/BlockExtensions/MediaTextInteractiveTest.php |
Updates contract import. |
tests/php/inc/Modules/Settings/FeaturesSettingsPageTest.php |
Updates settings utility import. |
tests/php/inc/Modules/Shortcodes/AuthorBioTest.php |
Updates contract import. |
README.md |
Updates package references and tree alignment. |
CONTRIBUTING.md |
Updates foundation package name. |
DEVELOPMENT.md |
Updates dependency guidance and example namespace. |
AGENTS.md |
Updates package and instruction references. |
CLAUDE.md |
Updates graph scope documentation. |
docs/quick-start-guide.md |
Updates setup commands and links. |
docs/knowledge-graph.md |
Updates sibling-repository graph workflow. |
bin/sync-ai.js |
Uses the renamed package’s sync script. |
bin/scaffold.config.js |
Updates an engine-reference comment. |
.github/copilot-instructions.md |
Updates package and rules references. |
.github/instructions/primitives-php.instructions.md |
Renames canonical framework guidance. |
.github/instructions/structure.instructions.md |
Updates merged-instruction reference. |
.github/prompts/init.prompt.md |
Updates bootstrap dependency instructions. |
.github/prompts/scaffold.prompt.md |
Updates dependency suggestion handling. |
.claude/skills/init/SKILL.md |
Updates local bootstrap guidance. |
.claude/skills/scaffold/SKILL.md |
Updates framework paths and package guidance. |
.claude/skills/setup/SKILL.md |
Updates PHPCS ruleset path. |
graphify-out/graph.json |
Partially renames generated graph entries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rebuilt with graphify update . and graphify cluster-only . --no-label --no-viz, as AGENTS.md describes. The committed graph was partly renamed by hand, so the primitives-php.instructions.md node still had instructions_framework_php_instructions IDs and edge endpoints. It was also built at 60ca769, before FeatureRegistry, FeaturesSettingsPage, AbstractThemeFeature, CONTRIBUTING.md and their tests existed.
AnuragVasanwala
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moves the shared engine dependency from
rtcamp/wp-frameworktortcamp/wp-primitives, per the decision in the WP Package namings thread. The theme keeps its own name.Depends on rtCamp/wp-primitives#98.
What changed
rtcamp/wp-framework ^1.0tortcamp/wp-primitives ^2.0, and the VCSrepositoriesURLrtCamp\WPFramework\tortCamp\WPPrimitives\acrossinc/and the test suite.github/instructions/framework-php.instructions.mdtoprimitives-php.instructions.md, plus the.claude/skills/initand.github/promptsreferences to itDEVELOPMENT.mdnow points changes at thertcamp/wp-primitivesrepository rather than a repo name that no longer existsREADME.md, sincewp-primitivesis one character longer thanwp-frameworkand had knocked the comment column outcomposer.lock is intentionally unchanged
It still describes
rtcamp/wp-framework@v1.0.1, which is what commit87774eeactually publishes. An earlier pass rewrote those entries in place to claim that tag publishesrtcamp/wp-primitiveswithrtCamp\WPPrimitives\, which is false, so it was reverted.composer validatewill therefore report that the lock does not satisfy the new^2.0constraint. That is the honest state. Regenerate withcomposer update rtcamp/wp-primitivesoncev2.0.0is tagged on the renamed library, which rewrites name, version, reference, dist, psr-4 and content-hash together.Do not merge yet
Merge after rtCamp/wp-primitives#98, and after the library repo is renamed and tagged
v2.0.0.Still outstanding
graphify-out/graph.jsonhas 19 node ids and edge endpoints still slugging the old instructions filename. Needs agraphify update .run rather than a hand edit, which would orphan edges.Verification
40 PHP files pass
php -l.bin/sync-ai.jspassesnode --check.composer.jsonvalidates.