Skip to content

Move to rtcamp/wp-primitives - #782

Merged
AnuragVasanwala merged 3 commits into
theme-elementary-v2from
rename/deps
Oct 1, 2026
Merged

AnuragVasanwala merged 3 commits into
theme-elementary-v2from
rename/deps

Conversation

@aryanjasala

Copy link
Copy Markdown
Member

Moves the shared engine dependency from rtcamp/wp-framework to rtcamp/wp-primitives, per the decision in the WP Package namings thread. The theme keeps its own name.

Depends on rtCamp/wp-primitives#98.

What changed

  • Dependency rtcamp/wp-framework ^1.0 to rtcamp/wp-primitives ^2.0, and the VCS repositories URL
  • Namespace rtCamp\WPFramework\ to rtCamp\WPPrimitives\ across inc/ and the test suite
  • .github/instructions/framework-php.instructions.md to primitives-php.instructions.md, plus the .claude/skills/init and .github/prompts references to it
  • DEVELOPMENT.md now points changes at the rtcamp/wp-primitives repository rather than a repo name that no longer exists
  • Realigned the directory tree in README.md, since wp-primitives is one character longer than wp-framework and had knocked the comment column out

composer.lock is intentionally unchanged

It still describes rtcamp/wp-framework@v1.0.1, which is what commit 87774ee actually publishes. An earlier pass rewrote those entries in place to claim that tag publishes rtcamp/wp-primitives with rtCamp\WPPrimitives\, which is false, so it was reverted.

composer validate will therefore report that the lock does not satisfy the new ^2.0 constraint. That is the honest state. Regenerate with composer update rtcamp/wp-primitives once v2.0.0 is tagged on the renamed library, which rewrites name, version, reference, dist, psr-4 and content-hash together.

Do not merge yet

Merge after rtCamp/wp-primitives#98, and after the library repo is renamed and tagged v2.0.0.

Still outstanding

graphify-out/graph.json has 19 node ids and edge endpoints still slugging the old instructions filename. Needs a graphify update . run rather than a hand edit, which would orphan edges.

Verification

40 PHP files pass php -l. bin/sync-ai.js passes node --check. composer.json validates.

- restore truthful composer.lock where the rename had falsified it
- correct unresolvable ^1.0 constraints in install docs
- document the HANDLE_PREFIX and text-domain breaks
- add the 1.0.x to 2.0.0 migration guide
- prune the superseded instructions file on sync
@aryanjasala aryanjasala mentioned this pull request Oct 1, 2026
@aryanjasala
aryanjasala marked this pull request as ready for review October 1, 2026 17:02
@aryanjasala
aryanjasala requested review from AnuragVasanwala and a balanced review from Copilot October 1, 2026 17:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The dependency remains uninstallable until v2.0.0 is tagged and the lockfile and generated graph are fully refreshed.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Migrates the theme’s shared PHP foundation from rtcamp/wp-framework to rtcamp/wp-primitives.

Changes:

  • Updates Composer dependency and PHP namespaces.
  • Revises tests, documentation, prompts, and AI instructions.
  • Partially updates the generated knowledge graph.
File Description
composer.json Switches package repository and constraint.
inc/​Main.php Updates framework trait namespace.
inc/​Abstracts/​AbstractThemeFeature.php Updates abstract and utility imports.
inc/​Core/​Assets.php Updates asset contracts and loader imports.
inc/​Core/​Components.php Updates component loader imports.
inc/​Core/​Encryption.php Updates encryption imports.
inc/​Core/​FeatureRegistry.php Updates feature utility imports.
inc/​Core/​Logger.php Updates logger imports.
inc/​Core/​Menu.php Updates registration contract import.
inc/​Core/​Templates.php Updates template loader imports.
inc/​Core/​ThemeSetup.php Updates registration contract import.
inc/​Modules/​Settings/​FeaturesSettingsPage.php Updates settings utility import.
inc/​Modules/​Settings/​ThemeOptions.php Updates settings abstract import.
tests/​php/​inc/​Core/​AssetsTest.php Updates contract assertion namespace.
tests/​php/​inc/​Core/​EncryptionTest.php Updates encryptor import.
tests/​php/​inc/​Core/​FeaturesTest.php Updates feature imports.
tests/​php/​inc/​Core/​LoggerTest.php Updates logger imports.
tests/​php/​inc/​Core/​MenuTest.php Updates contract assertion namespace.
tests/​php/​inc/​Core/​TemplatesTest.php Updates framework assertions.
tests/​php/​inc/​Core/​ThemeSetupTest.php Updates contract assertion namespace.
tests/​php/​inc/​Modules/​BlockExtensions/​MediaTextInteractiveTest.php Updates contract import.
tests/​php/​inc/​Modules/​Settings/​FeaturesSettingsPageTest.php Updates settings utility import.
tests/​php/​inc/​Modules/​Shortcodes/​AuthorBioTest.php Updates contract import.
README.md Updates package references and tree alignment.
CONTRIBUTING.md Updates foundation package name.
DEVELOPMENT.md Updates dependency guidance and example namespace.
AGENTS.md Updates package and instruction references.
CLAUDE.md Updates graph scope documentation.
docs/​quick-start-guide.md Updates setup commands and links.
docs/​knowledge-graph.md Updates sibling-repository graph workflow.
bin/​sync-ai.js Uses the renamed package’s sync script.
bin/​scaffold.config.js Updates an engine-reference comment.
.github/​copilot-instructions.md Updates package and rules references.
.github/​instructions/​primitives-php.instructions.md Renames canonical framework guidance.
.github/​instructions/​structure.instructions.md Updates merged-instruction reference.
.github/​prompts/​init.prompt.md Updates bootstrap dependency instructions.
.github/​prompts/​scaffold.prompt.md Updates dependency suggestion handling.
.claude/​skills/​init/​SKILL.md Updates local bootstrap guidance.
.claude/​skills/​scaffold/​SKILL.md Updates framework paths and package guidance.
.claude/​skills/​setup/​SKILL.md Updates PHPCS ruleset path.
graphify-out/​graph.json Partially renames generated graph entries.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread graphify-out/graph.json Resolved
Rebuilt with graphify update . and graphify cluster-only . --no-label --no-viz, as AGENTS.md describes. The committed graph was partly renamed by hand, so the primitives-php.instructions.md node still had instructions_framework_php_instructions IDs and edge endpoints. It was also built at 60ca769, before FeatureRegistry, FeaturesSettingsPage, AbstractThemeFeature, CONTRIBUTING.md and their tests existed.
@AnuragVasanwala
AnuragVasanwala merged commit dec6fe7 into theme-elementary-v2 Oct 1, 2026
1 check passed
@AnuragVasanwala
AnuragVasanwala deleted the rename/deps branch October 1, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants