Repository navigation
v2 release prep - #787
Merged
Merged
v2 release prep#787
Conversation
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.5 to 0.2.7. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.5...v0.2.7) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.3 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [launch-editor](https://github.com/vitejs/launch-editor) from 2.13.1 to 2.14.1. - [Commits](vitejs/launch-editor@v2.13.1...v2.14.1) --- updated-dependencies: - dependency-name: launch-editor dependency-version: 2.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [form-data](https://github.com/form-data/form-data) from 4.0.5 to 4.0.6. - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.29.0 to 7.29.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.6/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.29.6 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) and [@wp-playground/cli](https://github.com/WordPress/wordpress-playground). These dependencies needed to be updated together. Updates `ws` from 8.18.3 to 8.21.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.3...8.21.1) Updates `ws` from 8.19.0 to 8.21.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.3...8.21.1) Updates `ws` from 7.5.10 to 7.5.12 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.3...8.21.1) Updates `@wp-playground/cli` from 3.1.3 to 3.1.44 - [Release notes](https://github.com/WordPress/wordpress-playground/releases) - [Changelog](https://github.com/WordPress/wordpress-playground/blob/trunk/CHANGELOG.md) - [Commits](WordPress/wordpress-playground@v3.1.3...v3.1.44) --- updated-dependencies: - dependency-name: ws dependency-version: 8.21.1 dependency-type: indirect - dependency-name: ws dependency-version: 8.21.1 dependency-type: indirect - dependency-name: ws dependency-version: 7.5.12 dependency-type: indirect - dependency-name: "@wp-playground/cli" dependency-version: 3.1.44 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [websocket-driver](https://github.com/faye/websocket-driver-node) from 0.7.4 to 0.7.5. - [Changelog](https://github.com/faye/websocket-driver-node/blob/main/CHANGELOG.md) - [Commits](faye/websocket-driver-node@0.7.4...0.7.5) --- updated-dependencies: - dependency-name: websocket-driver dependency-version: 0.7.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps and [svgo](https://github.com/svg/svgo). These dependencies needed to be updated together. Updates `svgo` from 3.3.3 to 3.3.4 - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v3.3.3...v3.3.4) Updates `svgo` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v3.3.3...v3.3.4) --- updated-dependencies: - dependency-name: svgo dependency-version: 3.3.4 dependency-type: indirect - dependency-name: svgo dependency-version: 4.0.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.4 to 1.10.0. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.4...v1.10.0) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.10.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [immutable](https://github.com/immutable-js/immutable-js) from 5.1.5 to 5.1.9. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v5.1.5...v5.1.9) --- updated-dependencies: - dependency-name: immutable dependency-version: 5.1.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.10.0 to 5.10.1. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.10.0...v5.10.1) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.10.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.3...v3.1.4) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.10 to 8.5.22. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.10...8.5.22) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.22 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.4...v3.1.5) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.22 to 8.5.25. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.22...8.5.25) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.25 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Run Copilot code review on GitHub-hosted runners
Bumps and [postcss-selector-parser](https://github.com/postcss/postcss-selector-parser). These dependencies needed to be updated together. Updates `postcss-selector-parser` from 7.1.1 to 7.1.5 - [Release notes](https://github.com/postcss/postcss-selector-parser/releases) - [Changelog](https://github.com/postcss/postcss-selector-parser/blob/main/CHANGELOG.md) - [Commits](postcss/postcss-selector-parser@v7.1.1...7.1.5) Updates `postcss-selector-parser` from 6.1.2 to 6.1.4 - [Release notes](https://github.com/postcss/postcss-selector-parser/releases) - [Changelog](https://github.com/postcss/postcss-selector-parser/blob/main/CHANGELOG.md) - [Commits](postcss/postcss-selector-parser@v7.1.1...7.1.5) --- updated-dependencies: - dependency-name: postcss-selector-parser dependency-version: 7.1.5 dependency-type: indirect - dependency-name: postcss-selector-parser dependency-version: 6.1.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.5 to 3.1.7. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.5...v3.1.7) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@humanfs/node](https://github.com/humanwhocodes/humanfs/tree/HEAD/packages/node) from 0.16.7 to 0.16.8. - [Release notes](https://github.com/humanwhocodes/humanfs/releases) - [Changelog](https://github.com/humanwhocodes/humanfs/blob/main/packages/node/CHANGELOG.md) - [Commits](https://github.com/humanwhocodes/humanfs/commits/node-v0.16.8/packages/node) --- updated-dependencies: - dependency-name: "@humanfs/node" dependency-version: 0.16.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [joi](https://github.com/hapijs/joi) from 18.0.2 to 18.2.8. - [Commits](hapijs/joi@v18.0.2...v18.2.8) --- updated-dependencies: - dependency-name: joi dependency-version: 18.2.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#767) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.10.0 to 2.11.21. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.10.0...v2.11.21) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.11.21 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps and [svgo](https://github.com/svg/svgo). These dependencies needed to be updated together. Updates `svgo` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v3.3.4...v3.3.5) Updates `svgo` from 4.0.2 to 4.1.0 - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v3.3.4...v3.3.5) --- updated-dependencies: - dependency-name: svgo dependency-version: 3.3.5 dependency-type: indirect - dependency-name: svgo dependency-version: 4.1.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps and [js-yaml](https://github.com/nodeca/js-yaml). These dependencies needed to be updated together. Updates `js-yaml` from 3.14.2 to 3.15.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/3.15.2/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.2...3.15.2) Updates `js-yaml` from 4.1.1 to 4.3.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/3.15.2/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.2...3.15.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.15.2 dependency-type: indirect - dependency-name: js-yaml dependency-version: 4.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Consolidate onboarding, development, feature, and maintainer guidance, and build the documentation site through the shared workflow.
Bumps [adm-zip](https://github.com/cthackers/adm-zip) to 0.6.1 and updates ancestor dependency [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts). These dependencies need to be updated together. Updates `adm-zip` from 0.5.16 to 0.6.1 - [Release notes](https://github.com/cthackers/adm-zip/releases) - [Changelog](https://github.com/cthackers/adm-zip/blob/master/history.md) - [Commits](cthackers/adm-zip@v0.5.16...v0.6.1) Updates `@wordpress/scripts` from 31.5.0 to 35.0.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/scripts@35.0.0/packages/scripts) --- updated-dependencies: - dependency-name: adm-zip dependency-version: 0.6.1 dependency-type: indirect - dependency-name: "@wordpress/scripts" dependency-version: 35.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm install runs sync-ai (prepare hook), which regenerates the tracked .github/instructions/primitives-php.instructions.md from the installed framework. The committed copy predates AbstractAbility and AbstractFeature, so every fresh install left the tree dirty. Regenerated from the wp-primitives 2.0 candidate (#98 head) and corrected AGENTS.md, which claimed the file is absent until synced although it is committed for Copilot review.
246 errors were prettier formatting: these files used WordPress paren spacing while the resolved prettier (3.9.6, pulled in by @wordpress/eslint-plugin) enforces the standard style that src/ already follows. Fixed with eslint --fix. Seven needed a manual change: optional catch binding for two unused catch variables, eslint-disable-next-line for three deliberate console.warn calls in webpack.config.js, a reflowed eslint.config.mjs docblock line that jsdoc parsed as an @WordPress tag, and moving the excludeDirs early return ahead of the fullPath assignment in scanDirectory (same behaviour, satisfies no-unused-vars-before-return). Jest suite still passes (35/35).
lint:js only covered ./src, but the shared wp-ci lint-js job runs ESLint on every changed .js file in a PR. Root configs, bin/ scripts and tests/js were never linted locally and carried 253 errors, so any PR touching webpack.config.js, bin/* or a test would fail CI. eslint.config.mjs already ignores node_modules, vendor and assets/build.
PHPCS printed a deprecation on every run: passing array values as a comma-separated string has been deprecated since PHP_CodeSniffer 3.3 and is removed in 4.0, so the text-domain check would break on the PHPCS 4 upgrade. Matches the rtcamp/wp-phpcs example ruleset. The init engine still finds and rewrites the elementary-theme token.
#725 moved test:php and pretest:php from the cli container to tests-cli. wp-env (11.7) defaults the tests environment to WP_DEBUG false, so the framework Logger stays silent there and LoggerTest fails twice (test_levels_write_label_prefix_message_and_context asserts WP_DEBUG, test_no_context_omits_the_json_segment finds an empty log). #725 merged without a CI run, so this was never caught. Setting WP_DEBUG for the tests environment restores the behaviour the suite was written against. Verified on wp-env with PHP 8.2 and the latest core: 59 tests, 0 failures (was 2 failures).
workflow_run fires on every completion, failures included, and neither job checked the conclusion. rtBot has been merging red Dependabot bumps into main: #783 (09-30) and #780 (09-20) merged with Lint CSS, Lint JS and JS unit tests failing. - require workflow_run.conclusion == success, event == pull_request and a same-repository head before either job runs - match on workflow_run.actor.login instead of the spoofable github.actor (zizmor bot-conditions) - drop workflow-level write permissions and the unneeded checkout; gh gets the repo from GH_REPO and merges with GH_BOT_TOKEN (zizmor excessive-permissions, artipacked) - group concurrency on the triggering branch; github.head_ref is empty for workflow_run, so every run shared one group and cancelled the others actionlint clean; zizmor still reports dangerous-triggers for workflow_run itself, which is inherent to this pattern and mitigated because nothing from the PR is checked out or executed.
The Documentation workflow only ran for theme-elementary-v2 and only deployed from it. Once #692 lands v2 on main, docs changes on main would never build or deploy, and the docs site (still 404) would stay down. Builds now run for PRs and pushes on both branches; Pages deploys only from the repository default branch, so nothing changes until v2 is on main.
The setup skill said lint/phpcs/full uses vendor/rtcamp/wp-primitives/phpcs.xml.dist. The framework export-ignores that file (absent from dist installs), and it is the framework's internal config, not a consumer ruleset. Matches the wp-tooling fix that repoints the scaffold at rtCampWP-Basic from rtcamp/wp-phpcs.
…entary The theme pinned v24 (npm 11) while every shared wp-ci job installs Node 22 (npm 10), and the plugin skeleton pins 22. Following the theme's .nvmrc is how #777 produced an npm 11 lockfile that npm 10 rejects. npm 10 lockfiles install cleanly on npm 11, so 22 keeps local and CI on one lockfile format.
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.12 to 1.1.21. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.12...v1.1.21) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.21 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lint:js runs wp-scripts lint-js on the whole project since e38e947, so after any coverage run (npm run test:js -- --coverage writes tests/logs) it also linted tests/logs/lcov-report/*.js and failed with 6 eslint-comments errors. That broke lint:js, lint:all, lint:js:fix and lint-staged in any clone that had run coverage. Ignore tests/logs (the configured coverageDirectory) and coverage (the Jest default).
d9b0e0a described lint/phpcs/full as rtCampWP-Basic. wp-tooling golive/fixes (febd9e9) moved that scaffold to the strict rtCampWP standard, and this theme's own phpcs.xml.dist extends rtCampWP. Copy the wp-tooling setup skill row so both skills say the same thing.
Removing the settings example (also through --remove-examples) deleted all of inc/Modules/Settings, including the core FeaturesSettingsPage that inc/Main.php registers outside the example markers. The generated theme failed PHPStan with class.notFound for Modules\Settings\FeaturesSettingsPage, and since the Loader instantiates every Main::CLASSES entry it would fatal on boot. That is David's documented init flow (docs/initialization.md). The settings example now removes only ThemeOptions.php and its test. The block-extension example also removes its PHP and Jest tests, and the shortcode example also removes template-parts/author-bio.php, so a generated theme keeps no tests or templates for code it no longer has.
webpack.config.js also exports readAllFileEntries and toPort (same pattern as getComponentEntries; webpack only reads the config array) so the Jest suite can test them. Adds tests/js/media-text.test.js for the media-text frontend module.
…ions
Adds PHPUnit coverage for AbstractThemeFeature, the autoloader, Assets enqueueing, Util, ThemeOptions, MediaTextInteractive, AuthorBio, FeaturesSettingsPage, Features and ThemeSetup. The author-bio template assertion moves from TemplatesTest to AuthorBioTest, so removing the shortcode example removes it with the template.
Two cases are corrected against real WordPress: the text domain test reads the registry's protected custom_paths (WP_Textdomain_Registry has no has_custom_path()), and the settings test accepts the empty label and description defaults that register_setting() fills ('label' since WP 6.6). Dev VM: 101 tests, 267 assertions, 0 failures on PHP 8.2/WP 6.5 and PHP 8.4/WP 7.1; line coverage 34.98% to 88.48% (215/243).
main only carried Dependabot bumps to the v1 package.json and package-lock.json, which v2 replaces, so both keep the v2 versions. The org's copilot-code-review workflow comes across from main.
lint:* also matched lint:all itself and every :fix, report and lint:staged script, and test:* started the Jest watcher, so neither aggregate behaved as a check. Both now list the check scripts.
parseInt took 8888foo as 8888. BS_PORT and BLOCKS_DEV_SERVER_PORT now have to be all digits, so anything else falls back to the default; the toPort tests cover 8888foo, 30.5 and 0x10.
footer, hidden-404, media-text-interactive and page-creation-pattern call WordPress functions, so a direct request fatals. They now exit before any output, after the pattern header.
verify.sh looked for the interpreter through uv tool run, which installs graphify on demand, so it could report success on a machine without it. It now checks the installed uv tool environment only.
The rename left graph.json with mixed identities: nodes pointed at primitives-php.instructions.md while their ids and edge endpoints still said instructions_framework_php_instructions. Regenerated with graphify update . and graphify cluster-only . --no-label --no-viz (tree-sitter only, graphify 0.9.73). No old ids or machine-specific paths remain; the graph now also covers the code and tests added since June (754 to 999 nodes).
…/v2-into-main # Conflicts: # .claude/skills/init/SKILL.md # .claude/skills/scaffold/SKILL.md # .claude/skills/setup/SKILL.md # .github/prompts/init.prompt.md # AGENTS.md # CONTRIBUTING.md # DEVELOPMENT.md # README.md # bin/scaffold.config.js # bin/sync-ai.js # docs/knowledge-graph.md # docs/quick-start-guide.md # graphify-out/GRAPH_REPORT.md # graphify-out/graph.json
This was referenced Oct 1, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the v2 branch to release state. It contains #777, #778 and #782, so merging this with a merge commit closes all three, and it merges
mainin so #692 (v2 tomain) has no conflicts.Merge after rtCamp/wp-primitives#98 and #100, once the repository is renamed to
rtCamp/wp-primitivesandv2.0.0is tagged:composer.jsonrequiresrtcamp/wp-primitives ^2.0from that repository.Included PRs
rtcamp/wp-primitivesFixes
package-lock.jsoninstalls with npm 10, the version CI uses. The lock was written by npm 11 andnpm cifailed on npm 10 with "Missing: @emnapi/core from lock file" (af8c4cb)..nvmrcis pinned to Node 22 to match the shared CI (c3a6785).--remove-examples) deleted all ofinc/Modules/Settings/, including the coreFeaturesSettingsPage.phpthatinc/Main.phpstill registers. It now removes onlyThemeOptions.phpand its test, and the block-extension and shortcode examples also remove their own tests and template (8463198).text_domainproperty (be18a4e).WP_DEBUGis on in the wp-env tests environment, which two Logger tests rely on (f9050f1).src/, with the resulting ESLint errors fixed and Jest coverage output excluded (e38e947, 6cc43a9, 0219fcb).mainand v2 and deploys only from the default branch (dd8812f).lint/phpcs/fullas the strictrtCampWPstandard (2016fb1, d9b0e0a, 05980e7).Tests
New PHPUnit coverage for AbstractThemeFeature, the autoloader, asset enqueueing, Util, ThemeOptions, MediaTextInteractive, AuthorBio, FeaturesSettingsPage, Features and ThemeSetup, and Jest coverage for the webpack entry helpers and the media-text module (bd59d48, 22bce42).
Testing
Run locally, since the theme's CI cannot call the shared workflows yet:
theme-elementary-v2npm run build:prod: succeeds