Whattime refactor (accidentally includes driver control changes as well)#60
Merged
Conversation
…ive.java. Changed intake subsystem to use kraken built in motor encoder. Worked a lot on the shooter subsystem (it's somewhat functional probably). Let's pretend it isn't 1 in the morning.
… on initialization. Removed some position manager stuff.
… everything. Removed NamedCommands.java. Made intake motors public.
Contributor
Author
|
@caedmonmyers why does the intakeSubsystem now use a talonFX motor rather than the WhatTime Motor? |
Member
|
It uses talonfx because I was having trouble with WhatTime. But I think I figured it out. I just haven't had time to change it back yet. |
… more named commands. Moved intake angle motor back to WhatTime motor.
Contributor
Author
|
All good, was just curious. I'm planning on updating the library to not use the deprecated TalonFX command sometime soon, but from looking at it quickly it seems like it wont be an easy task. I'm not sure if I'm even going to update the java version for next year since im planning on using python instead. |
Contributor
Author
|
Good enough to merge now, no reason to keep the only code that we're using on a separate branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.