Skip to content

List resolved findings in their own section, and show their outcome on the finding page - #206

Merged
timini merged 1 commit into
mainfrom
claude/resolved-findings-ui
Oct 23, 2026
Merged

timini merged 1 commit into
mainfrom
claude/resolved-findings-ui

Conversation

@timini

@timini timini commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Pairs with the data repository's resolved-findings work (branch claude/resolved-findings in rewire-bio/rewire-benchmark-data), which emits settled findings the rules no longer find as resolved: true with their full follow-up history, an empty rule, no studies and no numbers. shared/omics/discrepancies.ts is copied from that branch: resolved?: boolean on Discrepancy, resolved: boolean on DiscrepancySummary, and resolved findings sorted last. It degrades gracefully: with the current release there are no resolved findings and the pages are unchanged.

/contested/:

  • Resolved findings never mix with the main list. They are listed below it under "Resolved", showing the label (linked), final state and last step date, e.g. "Confirmed error, 23 October 2026". The other filters apply to them too.
  • New status filter value resolved, which lists only them. "Settled" now means settled but not resolved, and the header counts resolved findings separately.

Finding page for a resolved finding:

  • Opens with "Resolved: confirmed error on 23 October 2026." and the last step's rationale, in place of the "automatic lead" notice.
  • With no studies, it says the compared results were withdrawn from the database (marked disputed) after the error was confirmed, so the comparison is not shown. Other outcomes get a plain "the check no longer finds this disagreement".
  • Keeps the full follow-up timeline. It leaves out the empty rule, model identity and compared-numbers sections, and replaces "How to help resolve this".

Open counts (home page, model pages, use-case badges) already count only unsettled findings, so resolved ones never appear in them; a test checks this.

Tests: tests/contested-results.test.tsx adds a resolved fixture (confirmed error, three steps) and covers the list totals, sections, filter, finding page and open counts. docs/contested-results.md is updated.

…ing's outcome and history on its page

Resolved findings (resolved: true, from schema 4 of the data file) are settled findings the rules no longer make. They stay out of the main list and open counts, appear under Resolved with their final state and date, and have their own status filter. Their page opens with the outcome and the last step's rationale, says why the comparison is not shown, and keeps the full timeline. The shared type matches the data repository's.
@timini
timini merged commit 8992548 into main Oct 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant