Repository navigation
List resolved findings in their own section, and show their outcome on the finding page - #206
Merged
Merged
Conversation
…ing's outcome and history on its page Resolved findings (resolved: true, from schema 4 of the data file) are settled findings the rules no longer make. They stay out of the main list and open counts, appear under Resolved with their final state and date, and have their own status filter. Their page opens with the outcome and the last step's rationale, says why the comparison is not shown, and keeps the full timeline. The shared type matches the data repository's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with the data repository's resolved-findings work (branch claude/resolved-findings in rewire-bio/rewire-benchmark-data), which emits settled findings the rules no longer find as
resolved: truewith their full follow-up history, an empty rule, no studies and no numbers.shared/omics/discrepancies.tsis copied from that branch:resolved?: booleanon Discrepancy,resolved: booleanon DiscrepancySummary, and resolved findings sorted last. It degrades gracefully: with the current release there are no resolved findings and the pages are unchanged./contested/:
resolved, which lists only them. "Settled" now means settled but not resolved, and the header counts resolved findings separately.Finding page for a resolved finding:
Open counts (home page, model pages, use-case badges) already count only unsettled findings, so resolved ones never appear in them; a test checks this.
Tests: tests/contested-results.test.tsx adds a resolved fixture (confirmed error, three steps) and covers the list totals, sections, filter, finding page and open counts. docs/contested-results.md is updated.