Repository navigation
Profiles: a renamed organizer is renamed on their meetups too - #326
Merged
Merged
Conversation
A meetup keeps its organizer's name and photo, shown as "Organized by …". onUserUpdated copied a new name onto posts, comments, rosters and the rest, but not onto the meetups the person organizes, which kept the old name until the meetup itself was edited. It now updates those too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A meetup keeps its organizer's name and photo (
organizerName,organizerAvatar). The app shows them as "Organized by …".onUserUpdatedcopies a new name and photo onto posts, comments, notifications, rosters, reviews, family, follower records and check-ins. It did not do this for the meetups the person organizes.updateMeetupCallablerefreshed those fields only when the meetup itself was edited, so a renamed organizer kept the old name on every meetup they had not touched since.onUserUpdatednow updates those meetups too, found byorganizerId.I found this while finding every copy of a pet's name for #325.
Test. One new emulator test:
The test fails on the old code. The full suite passes: 291 tests.
🤖 Generated with Claude Code