Repository navigation
Split each chapter's problems and quiz so the atlas loads only problems - #38
Merged
Merged
Conversation
Every lib/<ch>-data.tsx exported both PROBLEMS and QUIZ. The chapter page uses both, so webpack kept both in the module it shares with /atlas, and the atlas loaded thirteen chapters' quiz text it never shows (A#28). Each module is now two: lib/<ch>-problems.tsx (PROBLEMS, plus any constant only the problems use) and lib/<ch>-quiz.tsx (QUIZ). The arrays themselves are byte-identical to before. Chapter pages import both; app/atlas/page.tsx imports only the problem modules. CLAUDE.md's file map lists the new pair. /atlas First Load JS drops from 297 kB to 213 kB. Chapter pages are unchanged or up to 2 kB smaller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit item A#28.
The problem. Every
lib/<ch>-data.tsxexported bothPROBLEMSandQUIZ. Each chapter page uses both, so webpack kept both exports in the module it shares with/atlas. As a result, the atlas loaded the quiz text of 13 chapters that it never shows.The change:
lib/<ch>-problems.tsxholdsPROBLEMS, plus any constant that only the problems use (such as the array chapter'sTAG);lib/<ch>-quiz.tsxholdsQUIZ.PROBLEMSandQUIZarray againstmain.app/atlas/page.tsximports only the problem modules.CLAUDE.mdlists the new pair.Measurements
next build, First Load JS:main/atlasTest plan
PROBLEMSandQUIZsource text equals the original.npm run typecheck,npm test(103 passed),npm run build,npx playwright test(55 passed).🤖 Generated with Claude Code