Repository navigation
Boundary list: tick obstacles and delete them together - #236
Merged
Merged
Conversation
A tester redrawing a field's trees had over 40 obstacles to delete one row and one confirmation at a time. Each obstacle row now has a box in front of it, and the title row a box that ticks every obstacle (or none). Ticked obstacles are outlined red on the map; a bar under the list counts them, with Untick all and Delete ticked, and the trash button deletes them too, all after one confirmation. The outer boundary has no box and is never deleted this way. Ticks are kept by list row, so they all go when the list changes (a row added or deleted, an obstacle resized, another field); the host deletes nothing when its list has another length than the one ticked, or a row is not an obstacle (boundary.deleteObstacles|rows:i,j,k, MainViewModel.RemoteDeleteObstacles). Fork only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VKEBDFEFL88R13LC2YPU4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Renato · project thread
What changed
The boundary list can delete many obstacles at once. Redrawing a field's trees meant deleting over 40 obstacles one row and one confirmation at a time.
boundary.deleteObstacles|rows:i,j,k->MainViewModel.RemoteDeleteObstacles. It deletes nothing when its list has another length than the one ticked, or when a row is not an obstacle, so a row number never names another obstacle.Nothing else changes: one row selected and deleted with the trash button (nothing ticked) works as before. Fork only.
Related issue
None. Asked in the project thread (40+ trees to redraw).
Pre-submit checklist
dotnet buildsucceeds with no errorsdotnet test Tests/AgOpenWeb.ViewModels.Tests/: 775 passed, 6 new inDeleteTickedObstaclesTests(ticked ones go and the rest stay in order; all obstacles leave the outer; the outer among the rows, another list length, a row past the end and no row delete nothing; a row ticked twice is one obstacle)Tools/i18n-extract.py --check,Tools/license-headers.py --checkScreenshots
Picture in the project thread (
aow-screenshots/delete-ticked-obstacles.png): 8 ticked, the bar under the list, the confirmation.Generated by Claude Code