Repository navigation
Boundary menu: + Polygon draws an obstacle (from #624) - #237
Merged
Merged
Conversation
Beside "+ Circles": tap the corners of a ditch, a pond or a patch on the map (with the imagery under it), Undo, Finish and Cancel on the draw toolbar, Esc cancels. The host (RemoteAddObstacleFromMapPoints, command boundary.obstacle.fromMapPoints) drops a repeated tap on a corner and the closing tap, refuses a corner outside the field or a shape with no area, and adds the obstacle as Hard with the U-turn choice, saved with the field and selected in the list. Until now a non-round obstacle could only be recorded by driving round it or imported from KML. Brought to the fork from feature/obstacle-draw-polygon (official PR AgOpenGPS-Official#624, not merged yet), cherry-picked from e35212b onto pulverizador. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VKEBDFEFL88R13LC2YPU4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Renato · project thread
What changed
"+ Polygon" in the boundary menu, beside "+ Circles": draw an obstacle of any shape (a ditch, a pond, a pile of stones) by tapping its corners on the map, then Finish. Undo, Finish and Cancel are on the draw toolbar; Esc cancels.
boundary.obstacle.fromMapPoints->RemoteAddObstacleFromMapPoints(MainViewModel.ObstacleDraw.Remote.cs). A repeated tap on a corner and the closing tap are dropped; a corner outside the field or a shape with no area is refused. The obstacle is Hard with the U-turn choice, saved with the field and selected in the list.feature/obstacle-draw-polygon), cherry-picked ontopulverizadorwith no conflict. The fork review PR Boundary menu: "+ Polygon" draws an obstacle on the map (review copy) #73 was closed unmerged on 11-12, so it never reachedpulverizador. At the next sync after Boundary menu: "+ Polygon" draws an obstacle on the map AgOpenGPS-Official/AgOpenWeb#624 is merged the hunks are identical.Nothing else changes. Merges cleanly with #236 (tick and delete obstacles).
Related issue
Official PR AgOpenGPS-Official#624 (waiting, after v1.0). Asked in the project thread.
Pre-submit checklist
dotnet buildsucceeds with no errorsdotnet test --filter ObstacleCircle: 12 passed (the 3 polygon tests included)Screenshots
Picture in the project thread (
aow-screenshots/polygon-obstacle-drawing.png): six corners tapped, Undo / Finish / Cancel.Generated by Claude Code