Repository navigation
docs(product): record S3+S7 and S1+S2 shipped and S4+S5 in review in the FSMA 204 gap analysis - #3763
Draft
PetrefiedThunder wants to merge 3 commits into
Draft
PetrefiedThunder wants to merge 3 commits into
PetrefiedThunder wants to merge 3 commits into
Conversation
…A 204 gap analysis The 2026-10-28 gap analysis (merged as #3701, main 8c977b9) described four limits as unreported and two evidence gaps as open. Three of the sibling PRs it spawned have since landed or reached review, so the document's status columns no longer matched main. This change adds dated "Status 2026-10-30" notes next to the original findings instead of rewriting them, so the 2026-10-28 verification stays readable as the baseline. docs/product/FSMA_204_READINESS_GAP_ANALYSIS_2026-10-28.md: - Verification basis (line 7): one status line naming #3714 (main 2d43bf0), #3713 (main 80dfe96), #3717 (head 6c27050) and #3701. - Section 3 rows 9, 11, 13 and 14: repo-state, evidence and disposition columns record what shipped. Row 11 cites depth_exhausted and max_depth on TraceResponse in services/ingestion/app/canonical_router.py, the validated direction argument and per-direction depth flag in services/shared/cte_persistence/queries.py, and the direction query parameter on GET /api/v1/fda/trace/{tlc}. Row 13 cites EXPORT_EVENT_LIMIT in services/ingestion/app/epcis/persistence.py and the regengine:limit, regengine:truncated and regengine:ordering fields in the regengine:metadata block of services/ingestion/app/epcis/router.py, plus the cap copy in frontend/src/lib/customer-readiness.ts and docs/PRODUCT_DESCRIPTION.md. Row 14 cites the hashed evidence_context_<scope>_<timestamp>.json member built by _build_fda_package in services/ingestion/app/fda_export_service.py, with rule_versions from services/shared/rules/versions.py and known_gaps (including coverage_gate_bypassed for the allow_incomplete bypass) from _build_known_gaps in the same file. Row 9 cites the v141 append-only trigger (08c7cf36ddbe) on fsma.traceability_events, its column allowlist and the fsma.allow_mutation break-glass from #3717, and names role-gated break-glass authorization as a planned follow-up. - Section 7: the waiver-approver bullet notes S5 in review in #3717 (approver from the principal's key_id via _actor_from_principal). - Section 8: the /trace depth cap, FDA lineage depth, lineage direction and EPCIS LIMIT 2000 rows keep the 2026-10-28 answer and add the post-PR answer with the field names and PR numbers. - Section 9: the P1 list gains a status column per story (S1, S2, S3, S7 shipped; S4, S5 in review; S6, S8 open, unchanged). - Section 11: the PRODUCT_DESCRIPTION.md EPCIS-cap debt item is marked resolved by #3714. Departure from the brief: the brief described #3713 as in review. The GitHub record shows it merged to main at 80dfe96 on 2026-10-30 (after this branch's base fb4e5df), and its code was read at that commit, so S1 and S2 are recorded as shipped. The brief's citation services/ingestion/app/fda_export/known_gaps.py does not exist on main; the known-gaps builder lives in fda_export_service.py and is cited there. No other claim in the document was changed. Checks: scripts/check_docs_links.py, scripts/check_trust_safety_copy.py, scripts/ci/check_secrets_baseline.sh on the file, git diff --check, and a per-table column-count check all pass. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyhDYG3ddQvVKyu2qtYfCj
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Contributor
PR Blocker ChecklistHead SHA: Status: Ready
|
Collaborator
Author
|
Status 2026-11-02 12:30 UTC: head 99caf59 is green (PR Gate run 41431363775). It waits only on a
Generated by Claude Code |
12 of 16 tasks
…n-8fijxh-gap-status
#3717 merged as main 81f0ebc. The header, row 9, the section 7 waiver note and stories S4 and S5 said "in review, head 6c27050" and called role-gated break-glass authorization a planned follow-up with no PR; that follow-up is #3764 (v142 17fc5f9d1e69), now in review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GyhDYG3ddQvVKyu2qtYfCj
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only status update of
docs/product/FSMA_204_READINESS_GAP_ANALYSIS_2026-10-28.md(merged as #3701) now that three of its follow-up PRs have landed or are in review. Every original 2026-10-28 finding is kept verbatim; a dated "Status 2026-10-30" sentence is appended where the state changed, each checked against the code at the named main commits.TraceResponse.depth_exhausted/max_depth, directed lineage walk with per-direction depth limit,directiononGET /api/v1/fda/trace/{tlc};EXPORT_EVENT_LIMIT = 2000withregengine:limit/regengine:truncated/regengine:orderinginregengine:metadata; the hashedevidence_context_<scope>_<timestamp>.jsonmember withrule_versionsandknown_gaps; v141 append-only trigger and the planned role-gated break-glass follow-up).docs/PRODUCT_DESCRIPTION.mdEPCIS-cap item marked resolved by feat(export): state the EPCIS export cap and carry rule versions and known gaps in the FDA package #3714.Left as written on purpose (outside the brief, listed for a later pass): section 4's "the depth-cap flag is untested because it does not exist", row 12's "neither the audit row nor the package records it", and section 8's KDE-coverage "not an audit row" are partly stale after #3713/#3714.
Type of Change
Test Plan
Run locally:
scripts/check_docs_links.py(pass),scripts/check_trust_safety_copy.py(pass),scripts/ci/check_secrets_baseline.shon the file (pass),git diff --check(pass), a per-table column-count check over every table row (constant).Checklist
sys.modules[X] = stub, I justified it in the PR description (none)Related Issues
Relates to #3701, #3713, #3714, #3717.
Generated by Claude Code