Repository navigation
fix(ingestion): report unchecked EPCIS export integrity honestly - #3751
Conversation
PR Blocker ChecklistHead SHA: Status: Ready
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
|
REVIEW: PASS muse 346c5cd Independent Muse review, relayed by Codex from a completed read-only Muse CLI session. Muse reviewed the final diff and endpoint context pinned to this exact head; it did not run tests or access the repository directly. Muse found no material blocker:
Lead-executed validation: 40 passed, no skips, across the export, 1342, GS1/JSON-LD and legacy tenant-context suites. Ruff, formatting, hooks, Gitleaks and scoped TruffleHog checks passed. Limitations: this is not a cryptographic verifier or a production validation claim. Muse's review was static, based on supplied code; live storage/authentication and deployed behavior were not tested. Inherited retailer-compatibility wording and historical secret findings remain outside this patch. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: b1ab5108-4898-4c1b-a281-557ee1acc318) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Nonempty EPCIS exports previously set
chainHashVerified,integrityVerified, andX-RegEngine-Integrity-Verifiedto true merely because stored rows existed. Keep all three false until the export route performs cryptographic verification, and document that stored hashes are exported without verification.Supersedes #3750 using the accepted
codex/branch prefix. Conflicts were resolved against mainc770b2b7746365e6a9afecd10b4566977348d2df, preserving canonical EPC/GTIN handling, tenant-scoped KDE joins, transformations, structural validation, and skipped-event accounting. The change remains limited to three files.Verification
Exact reviewed and tested head:
346c5cd890d4807bcded9ae59c93445a93a11c97.b8c1e4f2a901.Review: #3751 (comment)
CI completion: https://github.com/regengine/RegEngine/actions/runs/40845584622/job/123361650727
Remaining limitations
Delivery
The isolated acceptance services were stopped and their task ports verified closed. No production credentials or customer data were used; generated raw keys stayed in memory. No application changes were needed after the tested commit.
Merged by squash as
9f3ff20aa668ca748641a1528bf998c3e22135d0on 2026-10-29 at 09:27:58 UTC. The merged Git tree exactly matches the reviewed/tested head. All four required checks passed before the merge; normal branch protections were enforced.No deployment or outreach was performed. Before merge, this Vercel project's Git integration was disconnected; its production deployment and domain assignments were verified unchanged. Post-merge checks found zero Vercel deployments for the merge SHA and no new Railway deployments. The Railway deployment workflow was already disabled and remains disabled. Vercel Git integration remains disconnected until a release is authorized, because reconnecting may trigger deployment. The reviewed remote branch was preserved, and the temporary branch-retention setting was restored.