Repository navigation
fix(ingestion): stop asserting unchecked EPCIS export integrity - #3750
Closed
PetrefiedThunder wants to merge 1 commit into
Closed
PetrefiedThunder wants to merge 1 commit into
PetrefiedThunder wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
PR Blocker ChecklistHead SHA: Status: Ready
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #3751
The conflicts are resolved against current main in draft #3751 on the permitted
codex/branch. GitHub does not support changing this PR's head branch, so #3751 replaces this draft without deleting its branch/history. The replacement has 40 passing tests with no skips and a completed independent Muse review at head346c5cd890d4807bcded9ae59c93445a93a11c97. Vercel preview creation was disabled and verified before its push. No PR was merged.Summary
chainHashVerified: true,integrityVerified: true, andX-RegEngine-Integrity-Verified: truesolely because rows existed. Return false until this route actually performs cryptographic verification, preserving the existing boolean contract.Type of Change
Test Plan
All evidence below applies to commit
bd00081a2069f8e0ee79dc2eef99e822e81e5157. Tests used the existing repository Python 3.11 virtual environment from the isolated worktree.Before the source fix, the nonempty-row case and both wrong-hash cases failed: 3 failed, 13 deselected. This reproduced the unsupported true flags. The passing suite also covers empty exports, storage failures, overflow behavior, and access-denial propagation. Storage is controlled/faked; the authentication-denial tests stub the authentication function boundary.
Additional checks:
Remaining limitations
Review gate blocker:
Engine Review Passcurrently fails with "Invalid author engine" because theopenclaw/branch prefix is not recognized. No review bypass or branch-policy change was made.Automatic preview: the GitHub push triggered Vercel deployment
dpl_xSKBpszsyF6t3JPsqqMak5nRhFLYfor this exact branch/head. It was alreadyREADYwhen inspected, so in-progress cancellation was no longer available. No deployment command, production promotion, or deployment-setting change was performed.Integration blocker: GitHub reports this draft as
CONFLICTING/DIRTY.mainadvanced 35 commits toc770b2b7746365e6a9afecd10b4566977348d2dfand changed the same export source/tests. The row-presence verification bug is still present there. This draft preserves the exact tested commit; conflict resolution and tests against the combined revision remain pending. The 24-test result applies only to the submitted head.This removes false verification claims; it does not implement a cryptographic verifier or detect tampering. False means integrity has not been established. Canonical event-content recomputation, chain linkage/membership, and snapshot-bound export verification remain separate work.
The full ingestion suite, live API-key backend, live database, and deployed behavior were not validated. Commit-blocking versus advisory runtime behavior and semantic TLC/omitted-CTE pilot gates remain outside this patch.
A broader TruffleHog history scan returned 188 unknown findings, zero verified findings, across 62 files and 48 older commits. None were in the three changed files. These remain unresolved and potentially live; clean patch scans do not clear repository history. No secret values are included here, and no exclusions, baselines, or credentials were changed.
Existing retailer-compatibility wording is inherited and was not validated by this change.
Checklist
sys.modulesstubs added.Related Issues
No issue linked.