copy(terms §7): qualify hashing claim by PetrefiedThunder · Pull Request #3669 · regengine/RegEngine

PetrefiedThunder · 2026-10-27T04:45:05Z

Summary

Terms Section 7: hashing claim qualified ('Where enabled... RegEngine feature, not an FDA requirement').
Requested by Legal: Lead Counsel (memo fsma204-status-and-copy-flags). Compliance date stays Jan 20, 2026 (87 FR 70910); FDA has said it will not enforce before July 20, 2028 per a Congressional directive.
Replaces copy(terms §7): qualify hashing claim #3659 (re-opened from an engine-prefixed branch with a Conventional Commit; same content, on current main). Author engine: codex; reviewer engine: claude.

Type of Change

Test Plan

Unit tests added/updated
Integration tests pass
Manual testing performed
N/A (copy-only text change; CI covers build/tests)

Checklist

My code follows the existing patterns in the codebase
I have not introduced hardcoded secrets or credentials
If this PR adds a test that uses sys.modules[X] = stub, I justified it in the PR description (N/A, none added)
I have updated relevant documentation (if applicable)
My changes generate no new warnings or lint errors (relying on CI Lint & Format; not run locally)

Related Issues

Relates to #3659

Note

Low Risk
Copy-only terms update with no runtime, auth, or data-handling changes; reduces overbroad legal/marketing claims.

Overview
Terms of Service §7 (Accuracy & Disclaimers) narrows how RegEngine describes cryptographic hashing so it matches legal guidance and optional product behavior.

The prior blanket statement that data is “cryptographically hashed and independently verifiable” is replaced with language that hashing applies where enabled on exports, can be checked with the open verification script, and is explicitly a RegEngine feature—not an FDA requirement. No other sections or UI logic change; only the static sections copy in TermsClient.tsx.

^{Reviewed by Cursor Bugbot for commit 86deef1. Bugbot is set up for automated code reviews on this repo. Configure here.}

vercel · 2026-10-27T04:45:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
regengine	Ready	Preview	Oct 28, 2026 4:07am UTC

chatgpt-codex-connector · 2026-10-27T04:45:19Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T04:45:58.145706Z	`8c97c4f`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-27T04:46:27Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: codex/legal-terms-hashing-claim
File: .coderabbit.yaml
Commit: 86deef1
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: d5595296-dbbd-4925-8936-5b2074ea7e00

Commits

Reviewing files that changed from the base of the PR and between 8c97c4f and 86deef1.

Files selected for processing: 1

frontend/src/app/terms/TermsClient.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The Accuracy & Disclaimers section now states that enabled exports include content hashes that can be checked with RegEngine’s open verification script. It also clarifies that hashing is a RegEngine feature, not an FDA requirement.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to 86dee

No actionable merge-blocking risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the Terms Section 7 change and the qualification of the hashing claim.
Description check		The description includes all required sections, explains the copy-only change, records the test plan, and links the related issue. The unchecked lint item is explained as not run locally and deferred …
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes all required sections, explains the copy-only change, records the test plan, and links the related issue. The unchecked lint item is explained as not run locally and deferred to CI.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

PetrefiedThunder · 2026-10-27T04:48:55Z

The PR passes. The new hashing sentence meets the qualifier rule and the code is safe. One sentence the PR did not touch is worth tightening in a later PR, but it does not block this one.

Legal accuracy

Hashing: Passes. The old text was an unqualified claim: "Our data is cryptographically hashed and independently verifiable." The new text limits it to exports ("Where enabled, exports include content hashes") and adds "Hashing is a RegEngine feature, not an FDA requirement." The "open verification script" it mentions exists in the product: frontend/src/app/verify/page.tsx lines 86 and 413 describe an Apache 2.0, open-source verification script.
Compliance date: Passes. The diff adds no dates, so nothing calls July 20, 2028 the compliance date.
21 CFR 1.1300: No new problem. The sentence "covers FDA Food Traceability List categories per 21 CFR 1.1300" was already there before this PR. It describes what the checker covers, not a statement that a given customer is covered. It is still loose wording: the Food Traceability List is a separate FDA document, and 1.1300 is the scope section that refers to it. A later PR could change it to "categories on FDA's Food Traceability List (see 21 CFR 1.1300)". Nothing in this PR has to change for that.

Code safety

The changed line is inside a JS template literal (content: `...`). The new text contains no backticks and no ${, so the literal still parses and no JSX or TypeScript breaks.
The diff changes one line in one file and nothing else.

Scope note

The diff you sent covers only TermsClient.tsx. Locally, git diff main...HEAD --stat shows 60 files changed, including services/ingestion/app/recall_report.py. That count probably includes earlier work that is not merged into main yet, such as the branch's previous commits like #3536. I reviewed only the diff you sent, not the other 59 files.

REVIEW: PASS claude 8c97c4f

github-actions · 2026-10-27T05:00:37Z

✅ Bundle Size Report

Metric	Size
Total JS	5564.4KB (5.43MB)
Total CSS	131.9KB
Limit	10.0MB

Bundle is within the 10.0MB limit.

github-actions · 2026-10-27T05:05:18Z

PR Blocker Checklist

Head SHA: 86deef16cdfab1467678cf3911bcfbcb2849e640

Status: Ready

All review threads resolved
No reviews requesting changes
No blocked review engines

github-actions · 2026-10-27T05:16:36Z

Vercel preview access note removed (A-2177 secret-hygiene cleanup).
Access is via Vercel login (Deployment Protection).

PetrefiedThunder

REVIEW: PASS grok 8c97c4f

One line change in TermsClient.tsx:74 qualifying the hashing claim. Verified the open verification script exists at frontend/public/sdk/verify_chain.py (Apache-2.0), served at https://regengine.co/sdk/verify_chain.py and linked from /proof and /verify. No data, no dashes, labels untouched.

Same line 74 conflict note as #3668: merge main in (no rebase), keep both wordings.

…hing-claim Signed-off-by: Christopher Sellers <1@christophersellers.com> # Conflicts: # frontend/src/app/terms/TermsClient.tsx

PetrefiedThunder

Codex delta review, 8c97c4f to 86deef1 (a merge of origin/main, no new PR commits).

The net diff is still one line, frontend/src/app/terms/TermsClient.tsx:74. The merge kept main's FTL Checker wording from #3668 ("informational tool ... not a coverage determination") and this PR's qualified hashing claim, each exactly once. There are no conflict markers or garbled text, and the TSX parses with zero syntax diagnostics. The "open verification script" the copy cites exists: frontend/public/sdk/verify_chain.py (Apache-2.0) checks export content hashes. The touched region adds no enforcement-date, Beta/EPCIS Preview, pricing, sale or invented-data issues. git diff --check is clean, and all required checks are green on this head.

Engine note: this PR's author engine is codex, so this codex PASS does not count as the non-author engine review. A claude or grok PASS on 86deef1 is still needed (grok's PASS is on 8c97c4f).

REVIEW: PASS codex 86deef1

PetrefiedThunder

PASS at 86deef1. Main merged in resolving line 74 conflict; keeps both #3668 and #3669 wording.

PetrefiedThunder · 2026-10-28T11:14:26Z

REVIEW: PASS claude 86deef1

Copy-only Terms §7 hashing qualifier in frontend/src/app/terms/TermsClient.tsx:74. Replaces the blanket "cryptographically hashed and independently verifiable" claim with "Where enabled, exports include content hashes you can check with our open verification script. Hashing is a RegEngine feature, not an FDA requirement." Open verification script confirmed at frontend/public/sdk/verify_chain.py (Apache-2.0). Main merge kept #3668 FTL Checker wording and this PR's hashing line with no conflict markers. No secrets, auth, injection, or runtime behavior changes. No blocking findings.

fix(copy): qualify hashing claim in terms section 7

8c97c4f

PetrefiedThunder mentioned this pull request Oct 27, 2026

copy(terms §7): qualify hashing claim #3659

Closed

vercel Bot deployed to Preview October 27, 2026 04:46

View deployment

PetrefiedThunder mentioned this pull request Oct 27, 2026

copy(terms §7): FTL checker is informational, not a coverage determination #3668

Merged

7 of 16 tasks

github-actions Bot added the frontend label Oct 27, 2026

PetrefiedThunder commented Oct 27, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into codex/legal-terms-has…

86deef1

…hing-claim Signed-off-by: Christopher Sellers <1@christophersellers.com> # Conflicts: # frontend/src/app/terms/TermsClient.tsx

vercel Bot deployed to Preview October 28, 2026 04:07

View deployment

PetrefiedThunder commented Oct 28, 2026

View reviewed changes

PetrefiedThunder merged commit 21a29d3 into main Oct 28, 2026
67 of 74 checks passed

PetrefiedThunder deleted the codex/legal-terms-hashing-claim branch October 28, 2026 11:21

Navigation Menu

Repository navigation

copy(terms §7): qualify hashing claim - #3669

copy(terms §7): qualify hashing claim#3669
PetrefiedThunder merged 2 commits into
mainfrom
codex/legal-terms-hashing-claim

PetrefiedThunder commented Oct 27, 2026 •

edited by cursor Bot

Loading

Uh oh!

vercel Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

PetrefiedThunder commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 27, 2026 •

edited by PetrefiedThunder

Loading

Uh oh!

PetrefiedThunder left a comment

Uh oh!

PetrefiedThunder left a comment

Uh oh!

PetrefiedThunder left a comment

Uh oh!

PetrefiedThunder commented Oct 28, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

PetrefiedThunder commented Oct 27, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Test Plan

Checklist

Related Issues

Uh oh!

vercel Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder commented Oct 27, 2026

Legal accuracy

Code safety

Scope note

Uh oh!

github-actions Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Bundle Size Report

Uh oh!

github-actions Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Blocker Checklist

Status: Ready

Uh oh!

github-actions Bot commented Oct 27, 2026 • edited by PetrefiedThunder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder commented Oct 28, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

PetrefiedThunder commented Oct 27, 2026 •

edited by cursor Bot

Loading

vercel Bot commented Oct 27, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

github-actions Bot commented Oct 27, 2026 •

edited

Loading

github-actions Bot commented Oct 27, 2026 •

edited

Loading

github-actions Bot commented Oct 27, 2026 •

edited by PetrefiedThunder

Loading