Skip to content

copy(terms §7): FTL checker is informational, not a coverage determination - #3668

Merged
PetrefiedThunder merged 1 commit into
mainfrom
codex/legal-terms-ftl-checker
Oct 27, 2026
Merged

PetrefiedThunder merged 1 commit into
mainfrom
codex/legal-terms-ftl-checker

Conversation

@PetrefiedThunder

@PetrefiedThunder PetrefiedThunder commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Terms Section 7: FTL checker described as an informational tool (see 21 CFR 1.1300), not a coverage determination.
  • Requested by Legal: Lead Counsel (memo fsma204-status-and-copy-flags). Compliance date stays Jan 20, 2026 (87 FR 70910); FDA has said it will not enforce before July 20, 2028 per a Congressional directive.
  • Replaces copy(terms §7): FTL checker is informational, not a coverage determination #3658 (re-opened from an engine-prefixed branch with a Conventional Commit; same content, on current main). Author engine: codex; reviewer engine: claude.

Type of Change

  • Bug fix
  • New feature
  • Enhancement to existing feature
  • Refactor (no behavior change)
  • Documentation
  • CI/CD or infrastructure
  • Security fix

Test Plan

  • Unit tests added/updated
  • Integration tests pass
  • Manual testing performed
  • N/A (copy-only text change; CI covers build/tests)

Checklist

  • My code follows the existing patterns in the codebase
  • I have not introduced hardcoded secrets or credentials
  • If this PR adds a test that uses sys.modules[X] = stub, I justified it in the PR description (N/A, none added)
  • I have updated relevant documentation (if applicable)
  • My changes generate no new warnings or lint errors (relying on CI Lint & Format; not run locally)

Related Issues

Relates to #3658

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
regengine Ready Ready Preview Oct 27, 2026 4:46am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T04:45:50.454528Z fc0954f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1f69633 and fc0954f.

Files selected for processing: 1
  • frontend/src/app/terms/TermsClient.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

Section 7 of the terms page now describes the FTL Checker as an informational tool based on the Food Traceability List published by the FDA. It states that the tool is not a coverage determination. The statement about cryptographic hashing and independent verification remains.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to fc095

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: Terms §7 copy now describes the FTL Checker as informational and not a coverage determination. It is specific and matches the summary and objectives. The title is 74 c…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the template's main sections (Summary, Type of Change, Test Plan, Checklist, Related Issues) and gives clear, specific context. It states the change: Terms Section 7 now descri…
Full details: Title check

Explanation

The title names the main change: Terms §7 copy now describes the FTL Checker as informational and not a coverage determination. It is specific and matches the summary and objectives. The title is 74 characters, which is within a normal title length, and the 'copy(terms §7):' prefix follows a Conventional Commit style.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Full details: Description check

Explanation

The description follows the template's main sections (Summary, Type of Change, Test Plan, Checklist, Related Issues) and gives clear, specific context. It states the change: Terms Section 7 now describes the FTL Checker as an informational tool, not a coverage determination. It cites the Legal request and memo, the compliance date, and the link to #3658. The Type of Change, Test Plan, and Checklist are filled in with reasons. Two items are unchecked or weakly supported: unit tests are not added, and lint was not run locally. The description does not include a 1-3 bullet summary of the code, but it does have bullets. Overall the description is mostly complete.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@PetrefiedThunder

Copy link
Copy Markdown
Collaborator Author

Review: #3668 (Terms §7, FTL Checker sentence)

Legal accuracy: passes

  • The old sentence said the tool "covers FDA Food Traceability List categories per 21 CFR 1.1300 with citations to specific CFR sections." That makes it sound like an authoritative coverage tool. The new sentence calls it "an informational tool" and says outright: "It is not a coverage determination." That meets the 1.1300 rule.
  • "(see 21 CFR 1.1300)" is a fair citation. That section sets out who the subpart applies to, by reference to foods on the FTL, and FDA does publish the list on its website. The sentence does not claim that 1.1300 contains the list or decides whether a business is covered.
  • It mentions no dates, so the 2026/2028 rules don't apply here.
  • The hashing sentence ("cryptographically hashed and independently verifiable") is unchanged. That one belongs to copy(terms §7): qualify hashing claim #3669, so it is not a defect here.

Code safety: passes

  • The new text sits inside a template literal. It contains no backticks and no ${, so the string can't break or interpolate. The diff changes one line and nothing else.
  • "FTL Checker" is the name already used on other tool pages (tools/kde-checker, tools/cte-mapper, and others), so the rename matches the rest of the site.
  • No test checks the old wording. The only "FTL Coverage Checker" hit is frontend/src/__tests__/public-site-fixes.test.tsx:62-66, and that test renders its own heading, not the terms copy. No tests were weakened. No meta description changed.

Not verified: I didn't run lint or build. This worktree is on codex/legal-site-2028-wording and doesn't have the #3668 diff applied, so I reviewed the diff text plus greps of this checkout.

REVIEW: PASS claude fc0954f

@github-actions

Copy link
Copy Markdown
Contributor

✅ Bundle Size Report

Metric Size
Total JS 5564.2KB (5.43MB)
Total CSS 131.9KB
Limit 10.0MB

Bundle is within the 10.0MB limit.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Vercel preview access note removed (A-2177 secret-hygiene cleanup).
Access is via Vercel login (Deployment Protection).

@github-actions

Copy link
Copy Markdown
Contributor

PR Blocker Checklist

Head SHA: fc0954f0d78f101ce9850900b3bf702eccea8b6c

Status: Ready

  • All review threads resolved
  • No reviews requesting changes
  • No blocked review engines

@PetrefiedThunder PetrefiedThunder left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEW: PASS grok fc0954f

One line change in frontend/src/app/terms/TermsClient.tsx:74 narrowing the FTL Checker to informational. No data, no dashes, labels untouched.

Note: #3669 rewrites the same line 74 off the same base 1f69633, so whichever merges second will conflict; merge main in (no rebase) and keep both the checker wording and the hashing wording.

@PetrefiedThunder
PetrefiedThunder merged commit 6c806c7 into main Oct 27, 2026
62 of 65 checks passed
@PetrefiedThunder
PetrefiedThunder deleted the codex/legal-terms-ftl-checker branch October 27, 2026 06:23

This branch was successfully deployed

1 active deployment
Preview — fc0954f0 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant