Repository navigation
fix(frontend): retitle Inflow Lab lot filter card to Lot code - #3571
Conversation
Signed-off-by: Christopher Sellers <1@christophersellers.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS muse cb7f510
This review covers only the stacked delta on top of #3569 (4b9bb40..cb7f510). That delta is one signed-off Conventional commit touching InflowLabClient.tsx, +3/-3:
- The card heading "Export filters" is now "Lot code", which matches its only remaining input, Traceability Lot Code.
- The CalendarDays icon is replaced by Tag. Tag is imported from lucide-react (L22) and used at L2320.
- The CalendarDays import is removed, and the file has no remaining references to it, so no unused import is left.
- No data, recall drill simulator, Load Sample Data or generateSampleCSV changes.
Base is gemini/fix-prod-404s (#3569), and the required gates must still go green on this head.
PR Blocker ChecklistHead SHA: Status: Ready
|
…rifier prefetch 404 (#3569) * fix(frontend): remove dead Inflow Lab mock export links and stop /proof verifier prefetch 404 Signed-off-by: Christopher Sellers <1@christophersellers.com> * fix(frontend): remove leftover Inflow Lab test handoff preview card Signed-off-by: Christopher Sellers <1@christophersellers.com> * fix(frontend): remove dead Inflow Lab export filters and preview cards, unused mock export routes, and /proof zip prefetch Signed-off-by: Christopher Sellers <1@christophersellers.com> * fix(frontend): drop empty Inflow Lab Test previews tab, stale date window copy, and half width lot filter Signed-off-by: Christopher Sellers <1@christophersellers.com> * fix(frontend): retitle Inflow Lab lot filter card to Lot code (#3571) Signed-off-by: Christopher Sellers <1@christophersellers.com> --------- Signed-off-by: Christopher Sellers <1@christophersellers.com>
Follow up to #3569, addressing Muse's nit in review 5637121983.
After #3569 removed the export preset and date inputs, the Inflow Lab card titled "Export filters" holds only the Traceability Lot Code input. This PR retitles it "Lot code" and swaps the calendar icon (
CalendarDays, now unused and dropped from the import) for lucideTag. No behavior change.Base: #3569 isn't merged yet, so this branch is cut from
gemini/fix-prod-404sand targets that branch. Once #3569 lands, retarget to main.Verification
tsc --noEmit: clean.vitest run inflow: 5 files, 51 tests passed.Note
Low Risk
Label and icon-only UI tweak in Inflow Lab with no logic, API, or data-handling changes.
Overview
Copy and icon alignment for the Inflow Lab Control room card that only exposes the Traceability Lot Code field (after export presets and date filters were removed elsewhere).
The card heading changes from Export filters to Lot code, and the header icon switches from
CalendarDaysto lucideTag, with the unusedCalendarDaysimport removed. The Traceability Lot Code input and behavior are unchanged.Reviewed by Cursor Bugbot for commit cb7f510. Bugbot is set up for automated code reviews on this repo. Configure here.