Skip to content

docs(copy): remove EDI and SFTP from supported-format copy - #3570

Merged
PetrefiedThunder merged 1 commit into
mainfrom
claude/ingest-copy-preview
Oct 24, 2026
Merged

PetrefiedThunder merged 1 commit into
mainfrom
claude/ingest-copy-preview

Conversation

@PetrefiedThunder

@PetrefiedThunder PetrefiedThunder commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Refs SEL-450, SEL-439, SEL-443.

Verification: tsc, lint, knip and vitest were not run locally because host load was above the 28 threshold. CI is the gate.


Note

Low Risk
Documentation and a display-label mapping only; no runtime ingestion, auth, or persistence behavior changes.

Overview
Aligns product and engineering docs with webhook, CSV, and EPCIS as the stated FSMA intake surfaces by stripping EDI (and EDI-style wording on the website) from PRODUCTION_SURFACE.md, README.md, REPO_PURPOSE.md, docs/PRODUCT_DESCRIPTION.md, and docs/product/WEBSITE_COPY.md. Capability tables, production-spine narrative, GS1 validation copy, and ingestion service descriptions no longer list EDI.

On the dashboard, frontend/src/app/records/page.tsx drops the edi entry from SOURCE_LABEL, so EDI-sourced records show the raw source_system value instead of “EDI”. No ingestion APIs, routers, or EDI implementation code are removed in this diff.

Reviewed by Cursor Bugbot for commit 06c7476. Bugbot is set up for automated code reviews on this repo. Configure here.

EPCIS 2.0 ingest tab already carries the Preview badge on main (#3405, #3471). Refs SEL-450, SEL-439, SEL-443.

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
@vercel

vercel Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
regengine Ready Ready Preview Oct 24, 2026 6:11am UTC

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T06:10:03.443345Z 06c7476 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between f177122 and 06c7476.

Files selected for processing: 6
  • PRODUCTION_SURFACE.md
  • README.md
  • REPO_PURPOSE.md
  • docs/PRODUCT_DESCRIPTION.md
  • docs/product/WEBSITE_COPY.md
  • frontend/src/app/records/page.tsx
Files with no reviewable changes: 1
  • frontend/src/app/records/page.tsx

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

Documentation no longer lists EDI as a supported intake format or ingestion responsibility. The records page removes the EDI source label mapping, so EDI source values display through the existing raw-value fallback.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to 06c74

The change is limited to documentation scope and existing UI fallback behavior, with no actionable merge-blocking risk established.

Architecture risk: Low · up to 06c74

The change affects 5 systems.

Changed systems: docs, frontend, PRODUCTION_SURFACE.md, README.md, REPO_PURPOSE.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 2 changed files map to changed impact.
  • observed — frontend (service) was modified; 1 changed file maps to changed impact.
  • observed — PRODUCTION_SURFACE.md (service) was modified; 1 changed file maps to changed impact.
  • observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in PRODUCTION_SURFACE.md: The active intake category now lists CSV and EPCIS FSMA data intake, removing EDI from the listed surfaces.
  • observed — Modified behavior in README.md: The capability inventory no longer lists EDI X12 ingest or EDI as a path using GS1 check-digit validation.
  • observed — Modified behavior in README.md: The direct-intake description no longer includes EDI among the routes with route-specific validation and persistence.
  • observed — Modified behavior in README.md: The ingestion service description no longer includes EDI in its listed responsibilities.
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the scope, intentional exclusions, related issue references, and verification status, but it does not use the required template sections. It omits the Type of Change and Check… Rewrite the description using the repository template. Add Summary, Type of Change with Documentation selected, Test Plan with the applicable N/A or CI-only result, Checklist with each applicable item selected, and Related Issues with SEL-4…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: removing EDI and SFTP from supported-format documentation and copy.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

Full details: Description check

Explanation

The description explains the scope, intentional exclusions, related issue references, and verification status, but it does not use the required template sections. It omits the Type of Change and Checklist sections and does not provide the required checkbox selections.

Resolution

Rewrite the description using the repository template. Add Summary, Type of Change with Documentation selected, Test Plan with the applicable N/A or CI-only result, Checklist with each applicable item selected, and Related Issues with SEL-450, SEL-439, and SEL-443.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 5
  • Waived: $1.25 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

Comment @coderabbitai help to get the list of available commands.

@PetrefiedThunder PetrefiedThunder left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head 06c7476. Removes EDI/EDI-style from supported-format copy in README, REPO_PURPOSE, PRODUCTION_SURFACE, PRODUCT_DESCRIPTION, WEBSITE_COPY and drops the EDI source label on /records. Repo-wide grep of frontend/src, frontend/public and docs at this head finds no remaining user-facing EDI/SFTP supported-format claims: remaining hits are internal ids (csv_sftp_import / csv-sftp, both rendered as 'CSV Import'), the IntegrationProfileSourceType union, capabilities.ts neverShown list, and research/audit/security/QA-artifact docs. No sample or invented data added. Nit (non-blocking): any legacy record with source_system 'edi' now renders the raw key 'edi' via the fallback at records/page.tsx:148,237. CI was still pending when reviewed (5 pass, 28 pending); merge needs green CI.

REVIEW: PASS codex 06c7476

@PetrefiedThunder
PetrefiedThunder enabled auto-merge (squash) October 24, 2026 06:20
@github-actions

Copy link
Copy Markdown
Contributor

✅ Bundle Size Report

Metric Size
Total JS 6340.2KB (6.19MB)
Total CSS 149.7KB
Limit 10.0MB

Bundle is within the 10.0MB limit.

@github-actions

Copy link
Copy Markdown
Contributor

PR Blocker Checklist

Head SHA: 06c7476db95eb90ae4f7a9347abd1ddbf74a14ad

Status: Ready

  • All review threads resolved
  • No reviews requesting changes
  • No blocked review engines

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Vercel preview access note removed (A-2177 secret-hygiene cleanup).
Access is via Vercel login (Deployment Protection).

@PetrefiedThunder
PetrefiedThunder merged commit 81db9d4 into main Oct 24, 2026
63 of 65 checks passed
@PetrefiedThunder
PetrefiedThunder deleted the claude/ingest-copy-preview branch October 24, 2026 08:03

This branch was successfully deployed

1 active deployment
Preview — 06c7476d Deployed Oct 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant