Repository navigation
chore: remove golden-path demo simulation - #3545
PetrefiedThunder wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: c04403af-a1f2-49dd-a1c8-353b3f624ed3) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PR Blocker ChecklistHead SHA: Status: Blocked (1 open blocker)Review Threads (0 unresolved)
Changes Requested (0)
Blocked Engines (1)
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description gives a clear summary, lists removed and retained files, and reports verification results. It does not follow the repository template because it omits the required Type of Change, Test… | Add the missing template sections. Mark the applicable change types, document the tests run and the unrun golden-path tests, complete the checklist, and state related issues or explicitly indicate that none apply. |
-
Check name Status Explanation Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely describes the main change: removal of the golden-path demo simulation. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
-
Full details: Description check
-
Explanation
The description gives a clear summary, lists removed and retained files, and reports verification results. It does not follow the repository template because it omits the required Type of Change, Test Plan, Checklist, and Related Issues sections.
Resolution
Add the missing template sections. Mark the applicable change types, document the tests run and the unrun golden-path tests, complete the checklist, and state related issues or explicitly indicate that none apply.
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: FAIL gemini 8157962
Code looks right, but there is no CI to rely on:
- Recall simulation untouched: the only change in scripts/run_recall_fixture.py is the docstring line ("DB-free by design, like scripts/run_full_fsma_simulation.py." becomes "DB-free by design."). No recall code, tests or endpoints changed.
- No dangling references: git grep at this SHA finds run_full_fsma_simulation only in docs/audits/RECALL_FIXTURE_AUDIT_2026-09-16.md and in dated docs/qa/2026-10-02 artifacts, both excluded. No workflow, Makefile, package.json or code imports it. tests/e2e/run_fsma_simulation.py is a separate script and is unaffected.
- No new data: the PR only deletes lines (plus one docstring edit).
- CI: the PR is CONFLICTING with main (mergeStateStatus DIRTY), so pull_request workflows did not run. The only run for this SHA is CodeQL (dynamic) plus Vercel. Backend CI, test-suite-check (tests/scripts) and the tests/integration/golden_path suite have no results. Please update the branch from main by merge, not rebase or force push, so CI runs. I will re-review once the backend and golden path jobs report.
Not merging: merge freeze.
…th-sim # Conflicts: # docs/GOLDEN_PATH.md # scripts/run_recall_fixture.py
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: ec892d7b-94b9-46f4-bdce-1b0ce2de0c8c) |
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: FAIL gemini 636f0f6
Content is correct. CI has one failure that this PR causes:
- Merge resolution is correct. #3512 (merged a0911dc) deleted scripts/run_recall_fixture.py, tests/scripts/test_run_recall_fixture.py and sample_data/recall_fixture/. None of them exist on main 03903ee or at this head. The diff against main is now only the golden-path simulation removal: README -6, docs/GOLDEN_PATH.md -21 (the "Fast Verification" section), the runbook -6, and the deleted scripts/run_full_fsma_simulation.py and its test. 493 deletions, 0 additions.
- No dangling references: git grep at this head finds no run_full_fsma_simulation, run_recall_fixture or recall_fixture anywhere outside docs/audits and docs/qa.
- No new data, since the PR only deletes lines.
- CI compared with main 03903ee (Backend run 39939184076):
- Test ingestion: identical, the same collection ERROR in tests/test_ingest_error_logging_2868.py (fixed by #3528).
- Repo-root suite: identical, 1 failed / 267 passed, test_check_supply_chain::test_real_tree_passes_with_committed_baseline.
- Test admin, compliance, nlp, graph, shared and scheduler and the Live DB suite pass. The Ingestion full suite and PR Gate: Backend were still pending.
- Caused by this PR: Commit Message Check fails because "Remove golden-path demo simulation ..." and the merge commit are not Conventional Commits. Fix the PR title to e.g. "chore: remove golden-path demo simulation" (squash uses the title); if the check still reads each commit, a maintainer decision is needed. Do not rewrite pushed commits.
- No CI job runs tests/integration/golden_path (no workflow references it), so it has no result. Please state how it was verified, or note it as a Coverage gap.
Not merging: merge freeze.
PetrefiedThunder
changed the title
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS gemini 636f0f6
- Head unchanged at 636f0f6, no code change since the last review. Title is now "chore: remove golden-path demo simulation" and the body has a "Coverage gap" section for tests/integration/golden_path.
- I ran my own check: git grep at this head for run_full_fsma_simulation, test_run_full_fsma, run_recall_fixture and recall_fixture under tests/integration/golden_path/ (init, conftest, helpers, test_golden_path) finds nothing. Deleting the script cannot affect those tests, so the Coverage gap note is acceptable.
- Commit Message Check is red but not required. The required checks are CI Status Gate, PR Gate: Backend/Frontend and PR Gate: Workflow Contract. The new title should be used for the squash.
- Backend failures match main 03903ee (run 39939184076):
- Test ingestion: same collection error in tests/test_ingest_error_logging_2868.py.
- Repo-root suite: same single failure, test_check_supply_chain::test_real_tree_passes_with_committed_baseline.
- Ingestion full suite (xdist): the same 8 FAILED/ERROR test ids as main.
- PR Gate: Backend is red only because it aggregates the Backend CI Status Gate.
- Non-blocking note: the PR body is out of date about scripts/run_recall_fixture.py. It lists a docstring edit and says the file and its tests are kept, but #3512 deleted them on main and this PR's diff doesn't touch them. Please correct the body.
Not merging: merge freeze.
Branch updated with mainMain was merged into Because merge commits created with GITHUB_TOKEN do not trigger workflows, a push to this branch or a manual CI re-run is needed for checks to run on it. Last synced: 2026-10-24T02:11:13.773Z |
Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS grok 95daa2c
Delta review of #3545 from my previous PASS at 20384c7.
The only commit since then is 95daa2c ("chore(ci): retrigger checks"), a single-parent empty commit on top of 20384c7. Its tree (a28f8be8487a) is identical to the previously reviewed tree; git diff 20384c7..95daa2c is empty. No content changed, so the prior PASS carries over to this head.
Posted with C.Lee's approval (Oct 23, 2026, 6:27 PM PT).
PetrefiedThunder
left a comment
PetrefiedThunder
left a comment
There was a problem hiding this comment.
Delta review: since the last PASS, the only change is a clean sync merge of main with no manual conflict resolution.
REVIEW: PASS pi d234870
Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
|
Superseded by #3559 (same tree, Conventional Commit history). Branch kept. |
Pull request was closed
* chore: remove golden-path demo simulation Removes scripts/run_full_fsma_simulation.py, its test, and doc references. Recall drill simulator, /proof/recall-drill and sample_recall_drill.csv are untouched. Replaces #3545. Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com> * docs: mark golden-path sim references as removed in recall audit Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com> --------- Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
Removes the golden-path demo simulation. C.Lee approved this himself at 12:14 PM PT on Oct 23, 2026.
Removed
scripts/run_full_fsma_simulation.pytests/scripts/test_run_full_fsma_simulation.py(only tested that script)Edited (references dropped)
README.md: removed the "fast golden contract" paragraph and commanddocs/GOLDEN_PATH.md: removed the "Fast Verification" section (script command and its /tmp artifacts)docs/runbooks/inflow_workbench_design_partner_demo.md: removed the "fast simulator" stepscripts/run_recall_fixture.pyandsample_data/recall_fixture/were deleted on main by test: remove invented sample_data, demo_exports, QA bad fixtures (SEL-447) #3512. After merging main, this PR no longer touches them, and the recall-fixture section in docs/GOLDEN_PATH.md was dropped with them.Intentionally kept
app.fda_export_service,shared.canonical_event,shared.cte_persistence,shared.rules.*). Many other files import them. The script's scenario data was inline, so no data files are removed.tests/integration/golden_path/andservices/ingestion/tests/test_compliance_e2e.py: separate tests that don't use the scriptdocs/GOLDEN_PATH.mdstays; the rest of it covers the golden-path narrativedocs/audits/anddocs/qa/still mention the script and are left unchangedThere was no Makefile, and no CI workflow, pyproject or
.secrets.baselineentry referred to the script.Checks
rg -n "run_full_fsma_simulation|regengine-golden-path"outside docs/audits and docs/qa finds nothingtests/scripts/test_check_docs_links.py: 25 passedReviewer: VS Code Gemini. Do not merge while the merge freeze is on.
Note
Low Risk
Documentation and deletion of a standalone demo script with no production or CI wiring; core FSMA pipelines and other tests remain untouched.
Overview
Removes the DB-free “fast golden contract” FSMA simulation (
scripts/run_full_fsma_simulation.py) and its dedicated script test. That runner simulated Inflow-style events, stateless rule evaluation, hash-chain evidence, and FDA CSV output without Postgres; it is no longer part of the recommended verification path.Docs now steer local proof at persisted evidence only: README,
docs/GOLDEN_PATH.md, and the Inflow design-partner runbook drop commands and narrative forrun_full_fsma_simulation.py//tmp/regengine-golden-path, and instead emphasizeverify_inflow_to_regengine_e2e.py(and the existing heaviere2e_brutal_scenario.pyin GOLDEN_PATH). Recall simulation app code, integration golden-path tests, and shared ingestion/rule modules are unchanged.Reviewed by Cursor Bugbot for commit 95daa2c. Bugbot is set up for automated code reviews on this repo. Configure here.
Coverage gap
No CI workflow runs
tests/integration/golden_path, so it never reported on this PR. It was not run locally either: the Mac has no project venv andhttpxis missing, and nothing was installed. Those tests do not import or invokescripts/run_full_fsma_simulation.py, which anrgacross the repo confirms, so deleting the script cannot affect them. Wiring golden_path into CI is a separate follow-up.