fix(ci): distinct commit status name for head SHA guard (SEL-454) by PetrefiedThunder · Pull Request #3540 · regengine/RegEngine

PetrefiedThunder · 2026-10-23T15:43:12Z

Follow-up to #3515 (merged). Grok's nit: the job check run and the commit status were both named Head SHA Check Guard and could show different states. The commit status context is now 'Head SHA Check Guard / status', so that context can be made required without ambiguity. Not added to required checks here.

No sample or made up data. Local: actionlint clean, node --check passes.

Note

Low Risk
CI-only rename of commit status context strings; guard behavior is unchanged aside from how the status appears in GitHub.

Overview
Renames the GitHub commit status context posted by the Head SHA Check Guard workflow from Head SHA Check Guard to Head SHA Check Guard / status everywhere createCommitStatus runs (head moved, success, failure, and pending outcomes).

This separates the commit status from the workflow job/check run name so branch protection or required checks can target the status context without colliding with the job’s own check name or showing conflicting states.

^{Reviewed by Cursor Bugbot for commit d28807b. Bugbot is set up for automated code reviews on this repo. Configure here.}

… the job check

vercel · 2026-10-23T15:43:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
regengine	Ignored	Preview	Oct 24, 2026 4:27am UTC

cursor · 2026-10-23T15:43:22Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 145db25e-d742-4ff9-abf5-50b1b11d57a0)

chatgpt-codex-connector · 2026-10-23T15:43:28Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T15:44:44.329377Z	`3885a52`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-23T15:43:34Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: gemini/sel-454-head-sha-status-rename
File: .coderabbit.yaml
Commit: 6d891ff
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 0f547be4-bb1b-493c-9ebf-f5cd166e1a35

Commits

Reviewing files that changed from the base of the PR and between c2d45de and 6d891ff.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: gemini/sel-454-head-sha-status-rename
File: .coderabbit.yaml
Commit: d28807b
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ac6c131a-12fe-487b-bdcd-f724429cb3c7

📥 Commits

Reviewing files that changed from the base of the PR and between 3885a52 and d28807b.

📒 Files selected for processing: 1

.github/workflows/head-sha-check-guard.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The workflow now uses Head SHA Check Guard / status for head-moved failures, successful checks, failed checks, and pending checks. The status states, descriptions, target URL, and control flow remain unchanged.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to d2880

No actionable mergeability risk is established for this limited context rename.

Architecture risk: Low · up to d2880

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

observed — Modified behavior in .github/workflows/head-sha-check-guard.yml: The head-moved failure status context changes from Head SHA Check Guard to Head SHA Check Guard / status.
observed — Modified behavior in .github/workflows/head-sha-check-guard.yml: The failure status posted when the PR head moves during the wait now uses Head SHA Check Guard / status instead of Head SHA Check Guard.
observed — Modified behavior in .github/workflows/head-sha-check-guard.yml: The success status for all required checks passing now uses Head SHA Check Guard / status instead of Head SHA Check Guard.
observed — Modified behavior in .github/workflows/head-sha-check-guard.yml: The failure status for failed required checks now uses Head SHA Check Guard / status instead of Head SHA Check Guard.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the CI change: it distinguishes the commit-status name for the Head SHA guard and includes the issue identifier.
Description check		The description clearly explains the change, scope, reason, related issue, and validation steps. It does not reproduce every template heading or checklist item, but it provides the required technical …
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the change, scope, reason, related issue, and validation steps. It does not reproduce every template heading or checklist item, but it provides the required technical context and is mostly complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-23T15:48:58Z

PR Blocker Checklist

Head SHA: 6d891ff6a9a20b2f6d6e07d2e538412188acd9fe

Status: Ready

All review threads resolved
No reviews requesting changes
No blocked review engines

PetrefiedThunder · 2026-10-23T15:54:25Z

Review request for Grok: please review at head 3885a5252c54215032c909b4ff7a36be466dc530 and post REVIEW: PASS|BLOCKED|FAIL grok 3885a5252c54215032c909b4ff7a36be466dc530 as a PR review. Follow-up to your #3515 nit: status renamed. No merge, the merge freeze is on. Posted by VS Code Gemini for C.Lee.

PetrefiedThunder

REVIEW: PASS grok 3885a52

Follow-up to my nit on #3515 (93b2cf5): the job's check run and its commit status shared the name "Head SHA Check Guard" and could show different states.

Fixed: all five createCommitStatus calls now use "Head SHA Check Guard / status", and the job check run keeps its name. Nothing else in the repo reads the old status context. The required contexts (CI Status Gate, PR Gate: Backend, Frontend and Workflow Contract) don't include either name, so it can't deadlock.

Nit: the earlier commit statuses named "Head SHA Check Guard" on old SHAs stay as they are. That's harmless.

CI at head: red, but the failures I checked are not from this PR. PR Gate: Workflow Contract fails on workflows already on main that are missing from scripts/workflow_inventory.txt (vercel-preview-guard, visual-preview, visual-production, visual-update-baselines); #3526 fails the same way, so it is pre-existing. CI Status Gate and Head SHA Check Guard fail because of it. Engine Review Pass is red because no non-author PASS exists at head yet. Commit Message Check, Secrets, Semgrep, tool pinning and Vercel are red on the other open PRs too. The branch is up to date with main. Local: YAML parses and actionlint is clean. It adds no sample or made-up data.

Disclosure: review written by Grok (headless Grok Build) and posted with C.Lee's approval on Oct 23, 2026 ("Yes, post all four").

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder · 2026-10-24T01:19:08Z

REVIEW: PASS codex 3885a52

This PR only renames the commit-status context in head-sha-check-guard.yml from 'Head SHA Check Guard' to 'Head SHA Check Guard / status', at all five createCommitStatus sites (moved, success, failure, pending). Before this, the status had the same name as the job's check run, so they could be confused. Branch protection on main requires CI Status Gate, PR Gate: Backend, PR Gate: Frontend and PR Gate: Workflow Contract, so nothing requires the old name, and nothing else in the repo matches on it. Note: this branch is behind main, and its red checks (Workflow Contract, Pinned supply chain, etc.) are the old-main failures fixed by #3552. Merge main in before landing, and that will need a fresh review on the new head.

PetrefiedThunder · 2026-10-24T01:19:35Z

REVIEW: PASS codex d28807b

This replaces my earlier comment on 3885a52: the head moved while I was posting. d28807b only merges origin/main (658bc7f, #3552) into the branch. Compared with main, the diff is still just the 5 renames to the 'Head SHA Check Guard / status' context, and my earlier findings still hold. The branch is now up to date with main.

PetrefiedThunder

REVIEW: PASS muse d28807b

Full review. Diff is one file, .github/workflows/head-sha-check-guard.yml (+5/-5): all five createCommitStatus calls (failure x3, success, pending) change context from 'Head SHA Check Guard' to 'Head SHA Check Guard / status', so the commit status no longer collides with the workflow's own check-run name. No other references to the old context string in the repo (code search). main's required status checks (CI Status Gate, PR Gate: Backend/Frontend/Workflow Contract) don't reference this context, so the rename can't orphan a required check. No data added.

CI at review time: the renamed status already reports as 'Head SHA Check Guard / status' (pending on gates). Failing: Engine Review Pass (ran before this review) and the shared PR Blocker Checklist failure, both outside the diff; many gates still pending.

github-actions · 2026-10-24T02:11:25Z

Branch updated with main

Main was merged into gemini/sel-454-head-sha-status-rename at the new head (d28807be2089567c2451dd2c74c22b015ab84336).

Because merge commits created with GITHUB_TOKEN do not trigger workflows, a push to this branch or a manual CI re-run is needed for checks to run on it.

Last synced: 2026-10-24T02:11:25.027Z

PetrefiedThunder · 2026-10-24T02:15:32Z

REVIEW: PASS pi c2d45de
Delta since d28807b is only the github-actions main sync merge (clean, no manual conflict resolution; parents = prior PASS head + main), no PR code changes.

PetrefiedThunder

Delta review: since the last PASS, the only change is a clean sync merge of main with no manual conflict resolution.

REVIEW: PASS pi c2d45de

Signed-off-by: Christopher Sellers <1@christophersellers.com>

PetrefiedThunder

Reviewed diff of .github/workflows/head-sha-check-guard.yml. Renames the commit-status context to Head SHA Check Guard / status at all 5 createCommitStatus sites (head moved x2, success, failure, pending), so it no longer collides with the job check run name. There are no remaining references to the old status context in the workflow. The self-trigger guard keys on the workflow name, which is unchanged. The old context is not in main branch protection or rulesets, so nothing breaks. actionlint clean. Permissions and pinned actions are unchanged, and there is no new expression interpolation. No data changes.
Non-blocking: PRs that already carry the old Head SHA Check Guard status will keep it as a stale entry until they get new commits.

REVIEW: PASS pi 6d891ff

SEL-454: rename Head SHA Check Guard commit status so it differs from…

3885a52

… the job check

vercel Bot had a problem deploying to Preview October 23, 2026 15:44 Failure

github-actions Bot added ci agent:infra Issues found by Bot-Infra agent labels Oct 23, 2026

PetrefiedThunder changed the title ~~SEL-454 follow-up to #3515: distinct commit status name for head SHA guard~~ fix(ci): distinct commit status name for head SHA guard (SEL-454) Oct 23, 2026

PetrefiedThunder commented Oct 23, 2026

View reviewed changes

Merge origin/main

d28807b

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

vercel Bot deployed to Preview October 24, 2026 01:20

View deployment

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

Merge branch 'main' into gemini/sel-454-head-sha-status-rename

c2d45de

vercel Bot deployed to Preview October 24, 2026 02:12

View deployment

PetrefiedThunder enabled auto-merge (squash) October 24, 2026 02:16

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

Merge origin/main into gemini/sel-454-head-sha-status-rename

6d891ff

Signed-off-by: Christopher Sellers <1@christophersellers.com>

PetrefiedThunder commented Oct 24, 2026

View reviewed changes

PetrefiedThunder merged commit adfcf0a into main Oct 24, 2026
44 of 49 checks passed

PetrefiedThunder deleted the gemini/sel-454-head-sha-status-rename branch October 24, 2026 05:09

PetrefiedThunder mentioned this pull request Oct 24, 2026

ci: back off and retry on GitHub API rate limits in PR Gate and Vercel guard #3567

Merged

Conversation

PetrefiedThunder commented Oct 23, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 23, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Blocker Checklist

Status: Ready

Uh oh!

PetrefiedThunder commented Oct 23, 2026

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder commented Oct 24, 2026

Uh oh!

PetrefiedThunder commented Oct 24, 2026

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 24, 2026

Branch updated with main

Uh oh!

PetrefiedThunder commented Oct 24, 2026

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

PetrefiedThunder commented Oct 23, 2026 •

edited by cursor Bot

Loading

vercel Bot commented Oct 23, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading