Skip to content

docs(readme): remove synthetic proof and recall-drill download links - #3498

Merged
PetrefiedThunder merged 3 commits into
mainfrom
claude/readme-proof-links
Oct 23, 2026
Merged

PetrefiedThunder merged 3 commits into
mainfrom
claude/readme-proof-links

Conversation

@PetrefiedThunder

@PetrefiedThunder PetrefiedThunder commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Removes README lines 17 and 19, which advertised the synthetic /proof downloads and the frozen-synthetic recall drill. README only. proof_recall_router.py, the samples and the recall-drill page are untouched; they wait for #3471.

Note: the /verify bullet (line 18) still says 'the public audit bundle'; left as is for review.


Note

Low Risk
Documentation-only README edits with no application, API, or deployment behavior changes.

Overview
README “Public proof surface” no longer lists synthetic try-it-yourself links for /proof downloads (FSMA CSV, EPCIS bundle, audit ZIP) or the frozen-dataset /proof/recall-drill demo.

The section now points readers only at regengine.co/verify, with copy updated so they verify audit bundles exported from their own workspace instead of a shared public bundle. Header links (e.g. “Public proof”) and runtime proof routes are unchanged in this PR.

Reviewed by Cursor Bugbot for commit 00dd6ab. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
regengine Ready Ready Preview Oct 23, 2026 10:22am UTC

@cursor

cursor Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: d314a2a6-2061-4c81-8530-f680f6031bd9)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T08:32:18.714970Z 086bc73 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between c9a8e32 and 00dd6ab.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 086bc73 and c9a8e32.

📒 Files selected for processing: 1
  • README.md

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The README public proof surface retains a link to verify a bundle exported from the user’s workspace. It removes the synthetic FSMA/EPCIS bundle download link and the public recall-drill endpoint link.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c9a8e

The README changes are accurate and do not alter verifier or route behavior.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the change: it removes the synthetic proof download links and the recall-drill link from the README. The raw summary confirms the README now lists only the audit-bundle verifier link, …
Description check Passed The description follows the template's intent. It states what changed (README lines 17 and 19 removed), why (synthetic /proof downloads and recall-drill advertising), and the scope (README only, with …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: it removes the synthetic proof download links and the recall-drill link from the README. The raw summary confirms the README now lists only the audit-bundle verifier link, and the objectives describe the same two-line removal. The title also uses the docs(readme) prefix, which matches a docs-only change. It does not mention the commit message's clarification about the verifier input, but that is a minor detail.

Full details: Description check

Explanation

The description follows the template's intent. It states what changed (README lines 17 and 19 removed), why (synthetic /proof downloads and recall-drill advertising), and the scope (README only, with the router, samples, and recall-drill page untouched pending #3471). It also flags a known leftover: the /verify bullet still says 'the public audit bundle'. The template sections (Type of Change, Test Plan, Checklist, Related Issues) are not filled in. The Test Plan is effectively N/A for a docs change, and the Checklist and Related Issues are absent. The description also contains bot-generated CURSOR_SUMMARY text. Those gaps are non-critical for a one-line docs change, so the description is mostly complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the docs label Oct 23, 2026

@PetrefiedThunder PetrefiedThunder left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS Code Muse review at 086bc73: FAIL

Both removals are confirmed: the synthetic /proof download line and the /proof/recall-drill line are gone.

Blocking: README.md:17 (the old line 18) still says "drop the public audit bundle into the verifier". That public bundle is synthetic:

  • frontend/public/proof/audit-bundle.zip (and audit-bundle-tampered.zip) are built by scripts/build_audit_bundle.sh from fsma-204-sample.csv.
  • The manifest the script writes says "_comment": "SYNTHETIC — RegEngine /proof audit bundle. Hashes are real; data is not." (build_audit_bundle.sh:76).
    Under the real-data rule, the README can't point users at it. app/verify/page.tsx:66-68 already says "Export your own bundle... the audit bundle ZIP you exported from your RegEngine workspace". Please reword the line to match, for example: "regengine.co/verify: drop an audit bundle exported from your own workspace into the verifier and confirm file-hash and Merkle-root integrity."

Follow-up (separate PR): remove the synthetic files in frontend/public/proof/ (audit-bundle.zip, audit-bundle-tampered.zip, epcis-sample.jsonld, fsma-204-sample.csv), scripts/build_audit_bundle.sh, and demo_exports/sample_audit_bundle.json.

…own workspace

Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
@cursor

cursor Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 684958b7-a99f-4951-94ab-2411e711b26f)

@cursor

cursor Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: b5f34cca-f618-44c6-98ac-385ecfcc7bbe)

@PetrefiedThunder
PetrefiedThunder merged commit 11f9f7f into main Oct 23, 2026
8 of 9 checks passed
@PetrefiedThunder
PetrefiedThunder deleted the claude/readme-proof-links branch October 23, 2026 10:20
@github-actions

Copy link
Copy Markdown
Contributor

PR Blocker Checklist

Head SHA: 00dd6ab6f14263cb1265b74bba4c62d2bb804c72

Status: Ready

  • All review threads resolved
  • No reviews requesting changes
  • No blocked review engines

@PetrefiedThunder PetrefiedThunder left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEW: PASS 00dd6ab (content). Authored delta since 086bc73 is c9a8e32: README.md:17 now reads "drop an audit bundle exported from your own workspace into the verifier…"; no synthetic/public sample bundle presented as real, no made-up data added. 00dd6ab is a merge of main; its other changes are main's, not this PR's. Note: this PR was already merged at 3:20 AM PT (during the freeze window) with CI failing: PR Gate: Secrets and CI Status Gate fail (21 pass, 3 skipped). This review is after the fact; it is not an approval of that merge.

This branch was successfully deployed

1 active deployment
Preview — 00dd6ab6 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant