Skip to content

fix(list): hide divider on final inset item - #23

Merged
rdlabo merged 2 commits into
mainfrom
fix/inset-list-last-divider
Aug 22, 2026
Merged

fix(list): hide divider on final inset item#23
rdlabo merged 2 commits into
mainfrom
fix/inset-list-last-divider

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • exclude the final ion-item in an inset ion-item-group from the MD3 divider rule
  • keep single-item groups divider-free
  • preserve dividers between items in multi-item groups
  • align the behavior with the ios26 theme

Verification

  • npm run lint
  • npm run build
  • confirmed the compiled selector includes :not(:last-of-type)

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-23/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo

rdlabo commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@rdlabo
rdlabo marked this pull request as ready for review August 22, 2026 01:56
@rdlabo
rdlabo merged commit 4eba512 into main Aug 22, 2026
8 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

passed  78 passed

Details

stats  78 tests across 1 suite
duration  1 minute, 34 seconds
commit  c36d798
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-23/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant