Skip to content

chore: unify ESLint config to winecode standard #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlabo merged 1 commit into from
Jun 18, 2026
Merged

chore: unify ESLint config to winecode standard #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,15 @@ module.exports = tseslint.config(
],
processor: angular.processInlineTemplates,
rules: {
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-explicit-any": "off",
"no-async-promise-executor": "off",
"no-prototype-builtins": "off",
Comment on lines +21 to +22

@devin-ai-integration devin-ai-integration Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Broad lint rule suppressions may mask real issues

This PR disables no-async-promise-executor and no-prototype-builtins globally. Both of these rules catch real bug patterns: no-async-promise-executor catches cases where errors in async promise executors won't properly reject the promise, and no-prototype-builtins catches cases where calling .hasOwnProperty() on objects without Object.prototype can throw. These are typically suppressed per-line rather than globally. This may be intentional to get a clean lint pass after the dependency upgrade introduced stricter defaults, but it could also mask legitimate issues in the codebase.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"no-irregular-whitespace": "off",
"no-unexpected-multiline": "off",
"@angular-eslint/no-empty-lifecycle-method": "off",
"@angular-eslint/directive-selector": "off",
"@angular-eslint/component-selector": "off",
},
Expand All @@ -26,6 +33,9 @@ module.exports = tseslint.config(
...angular.configs.templateRecommended,
...angular.configs.templateAccessibility,
],
rules: {},
rules: {
"@angular-eslint/template/click-events-have-key-events": "off",
"@angular-eslint/template/interactive-supports-focus": "off",
},
}
);
Loading