chore: unify ESLint config to winecode standard - #5
Merged
Conversation
Align the non-@rdlabo ESLint setup to the winecode/app standard, unify dependency versions across the fleet, and fix resulting violations so `ng lint` passes. - rules: selector / component-class-suffix / prefer-on-push and the 8-rule off-set aligned to winecode; off-rules not in the standard removed - versions: eslint ^9.39.4, @eslint/js ^9.39.4, typescript-eslint ^8.61.1, angular-eslint 21.4.0 - keep lint green (pre-existing debt fixed as needed) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ch5Dua6sbthgLJSbPAAENF
❌ Deploy Preview for rdlabo-ionic-angular-library failed.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+21
to
+22
| "no-async-promise-executor": "off", | ||
| "no-prototype-builtins": "off", |
Contributor
There was a problem hiding this comment.
🚩 Broad lint rule suppressions may mask real issues
This PR disables no-async-promise-executor and no-prototype-builtins globally. Both of these rules catch real bug patterns: no-async-promise-executor catches cases where errors in async promise executors won't properly reject the promise, and no-prototype-builtins catches cases where calling .hasOwnProperty() on objects without Object.prototype can throw. These are typically suppressed per-line rather than globally. This may be intentional to get a clean lint pass after the dependency upgrade introduced stricter defaults, but it could also mask legitimate issues in the codebase.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ESLint 設定を winecode/app 基準に統一し、依存バージョンを揃え、
ng lintが green になるまで修正しました。@rdlabo/eslint-plugin-rules系のルールは各 repo 固有のまま維持しています。変更
deny-constructor-diは撤去）^9.39.4/ @eslint/js^9.39.4/ typescript-eslint^8.61.1/ angular-eslint21.4.0検証
npm run lint→ All files pass linting (green)npm test通過🤖 Generated with Claude Code
https://claude.ai/code/session_01Ch5Dua6sbthgLJSbPAAENF