Skip to content

fix(kit): add repository.url for npm provenance #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlabo merged 1 commit into from
Jul 14, 2026
Merged

fix(kit): add repository.url for npm provenance #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"name": "@rdlabo/ionic-angular-kit",
"version": "21.2.0-2",
"repository": {
"type": "git",
"url": "https://github.com/rdlabo-team/ionic-angular-library.git"

@devin-ai-integration devin-ai-integration Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 リポジトリURLの形式が他のパッケージと一致しない

新しく追加されたリポジトリURLがHTTPS形式（projects/kit/package.json:6）で指定されているが、同リポジトリ内の他の全パッケージはSSH形式を使用しているため、パッケージ間でメタデータの一貫性が失われる。

Impact: npmパッケージのメタデータに一貫性がなくなり、ツールやスクリプトがリポジトリURLを比較・処理する際に不整合が生じる可能性がある。

他パッケージとのURL形式の不一致の詳細

既存の他パッケージはすべてSSH形式を使用している:

  • projects/photo-editor/package.json: git@github.com:rdlabo-team/ionic-angular-library.git
  • projects/scroll-header/package.json: git@github.com:rdlabo-team/ionic-angular-library.git
  • projects/scroll-strategies/package.json: git@github.com:rdlabo-team/ionic-angular-library.git

一方、今回追加された projects/kit/package.json では https://github.com/rdlabo-team/ionic-angular-library.git が使用されている。

Suggested change
"url": "https://github.com/rdlabo-team/ionic-angular-library.git"
"url": "git@github.com:rdlabo-team/ionic-angular-library.git"
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

},
"peerDependencies": {
"@angular/common": "^21.0.0",
"@angular/core": "^21.0.0",
Expand Down