fix(kit): add repository.url for npm provenance - #18
Merged
Conversation
Empty repository.url fails sigstore validation (E422) when publishing with --provenance. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| "version": "21.2.0-2", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/rdlabo-team/ionic-angular-library.git" |
Contributor
There was a problem hiding this comment.
🟡 リポジトリURLの形式が他のパッケージと一致しない
新しく追加されたリポジトリURLがHTTPS形式（projects/kit/package.json:6）で指定されているが、同リポジトリ内の他の全パッケージはSSH形式を使用しているため、パッケージ間でメタデータの一貫性が失われる。
Impact: npmパッケージのメタデータに一貫性がなくなり、ツールやスクリプトがリポジトリURLを比較・処理する際に不整合が生じる可能性がある。
他パッケージとのURL形式の不一致の詳細
既存の他パッケージはすべてSSH形式を使用している:
projects/photo-editor/package.json:git@github.com:rdlabo-team/ionic-angular-library.gitprojects/scroll-header/package.json:git@github.com:rdlabo-team/ionic-angular-library.gitprojects/scroll-strategies/package.json:git@github.com:rdlabo-team/ionic-angular-library.git
一方、今回追加された projects/kit/package.json では https://github.com/rdlabo-team/ionic-angular-library.git が使用されている。
Suggested change
| "url": "https://github.com/rdlabo-team/ionic-angular-library.git" | |
| "url": "git@github.com:rdlabo-team/ionic-angular-library.git" |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v21.2.0-2で kit のみ publish 失敗（他 lib は成功）。kit の
package.jsonに他 lib 同様のrepositoryを追加。Test plan
prebuild:kit後にdist/kit/package.jsonに repository が入る21.2.0-3を切り直し（kit が@betaに載る）Made with Cursor