Skip to content

Add SHA info to version #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstruman merged 1 commit into from
Jul 7, 2026
+10 −7
Merged

Add SHA info to version #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions tracing/tracer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import (

otelpropagation "go.opentelemetry.io/otel/propagation"
oteltrace "go.opentelemetry.io/otel/trace"

"github.com/rdkcentral/webconfig/common"
)

const (
Expand Down Expand Up @@ -108,13 +110,14 @@ func (t *XpcTracer) Region() string {
}

func initAppData(xpcTracer *XpcTracer, conf *configuration.Config) {
codeGitCommit := strings.Split(conf.GetString("webconfig.code_git_commit"), "-")
xpcTracer.appName = codeGitCommit[0]
if len(codeGitCommit) > 1 {
xpcTracer.appVersion = codeGitCommit[1]
}
if len(codeGitCommit) > 2 {
xpcTracer.appSHA = codeGitCommit[2]
codeGitCommit := conf.GetString("webconfig.code_git_commit")
cgcData := strings.SplitN(codeGitCommit, "-", 2)
xpcTracer.appName = cgcData[0]
xpcTracer.appVersion = codeGitCommit
// Fall back to the build-time binary version if code_git_commit is empty.
// This ensures service.version is always populated in OTel resource attributes.
if xpcTracer.appVersion == "" {
xpcTracer.appVersion = common.BinaryVersion
}
Comment thread
lstruman marked this conversation as resolved.

// Env vars
Expand Down