Add SHA info to version#326
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates tracing initialization so OpenTelemetry service.version can include the build SHA (instead of only the version), with a fallback to a build-time version when the config value is empty.
Changes:
- Updates
initAppDataparsing ofwebconfig.code_git_committo populateappVersionfrom the config string. - Adds fallback logic to use
common.BinaryVersionwhencode_git_commitis empty. - Adds
commonimport to support the fallback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lstruman
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the version-SHA to be added to the traces instead of just the version.