Skip to content

Get the pipeline position instead of video sink position when syncing the subtitles #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skywojciechowskim merged 2 commits into from
Jul 14, 2026
+24 −30
Merged

Get the pipeline position instead of video sink position when syncing the subtitles #558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8af63bf
fix
skywojciechowskim Jul 3, 2026
06655f9
Merge branch 'release/v0.15.2' into SubtitlesOutOfSync
skywojciechowskim Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions media/server/gstplayer/source/tasks/generic/SynchroniseSubtitleClock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,49 +42,43 @@ SynchroniseSubtitleClock::~SynchroniseSubtitleClock()
void SynchroniseSubtitleClock::execute() const
{
RIALTO_SERVER_LOG_DEBUG("Executing SynchroniseSubtitleClock");
if (m_context.videoSink)
gint64 position = m_player.getPosition(m_context.pipeline);
if (position == -1)
{
gint64 position = 0;
if (m_gstWrapper->gstElementQueryPosition(m_context.videoSink, GST_FORMAT_TIME, &position))
{
RIALTO_SERVER_LOG_DEBUG("Videosink position: %" PRId64 " ns", position);
}
RIALTO_SERVER_LOG_WARN("Getting the position failed");
return;
}

auto sourceElem = m_context.streamInfo.find(MediaSourceType::SUBTITLE);
GstElement *source{nullptr};
auto sourceElem = m_context.streamInfo.find(MediaSourceType::SUBTITLE);
GstElement *source{nullptr};

if (sourceElem != m_context.streamInfo.end())
{
source = sourceElem->second.appSrc;
}
else
{
RIALTO_SERVER_LOG_WARN("subtitle source not found");
return;
}
if (sourceElem != m_context.streamInfo.end())
{
source = sourceElem->second.appSrc;
}
else
{
RIALTO_SERVER_LOG_WARN("subtitle source not found");
return;
}

GstStructure *structure = m_gstWrapper->gstStructureNew("current-pts", "pts", G_TYPE_UINT64, position, nullptr);
GstEvent *event = m_gstWrapper->gstEventNewCustom(GST_EVENT_CUSTOM_DOWNSTREAM_OOB, structure);
GstStructure *structure = m_gstWrapper->gstStructureNew("current-pts", "pts", G_TYPE_UINT64, position, nullptr);
GstEvent *event = m_gstWrapper->gstEventNewCustom(GST_EVENT_CUSTOM_DOWNSTREAM_OOB, structure);
Comment thread
skywojciechowskim marked this conversation as resolved.

if (event)
if (event)
{
if (m_gstWrapper->gstElementSendEvent(source, event))
{
if (m_gstWrapper->gstElementSendEvent(source, event))
{
RIALTO_SERVER_LOG_DEBUG("Sent current-pts event to subtitlesource");
}
else
{
RIALTO_SERVER_LOG_ERROR("Failed to send current-pts event to source");
}
RIALTO_SERVER_LOG_DEBUG("Sent current-pts event to subtitlesource");
}
else
{
RIALTO_SERVER_LOG_ERROR("Failed to create current-pts event");
RIALTO_SERVER_LOG_ERROR("Failed to send current-pts event to source");
}
}
else
{
RIALTO_SERVER_LOG_ERROR("video-sink is NULL");
RIALTO_SERVER_LOG_ERROR("Failed to create current-pts event");
}
}

Expand Down
Loading