Skip to content

Get the pipeline position instead of video sink position when syncing the subtitles#558

Merged
skywojciechowskim merged 2 commits into
release/v0.15.2from
SubtitlesOutOfSync
Jul 14, 2026
Merged

Get the pipeline position instead of video sink position when syncing the subtitles#558
skywojciechowskim merged 2 commits into
release/v0.15.2from
SubtitlesOutOfSync

Conversation

@skywojciechowskim

Copy link
Copy Markdown
Contributor

Summary: Get the pipeline position instead of video sink position when syncing the subtitles
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-21216

Copilot AI review requested due to automatic review settings July 13, 2026 09:25
@github-actions

Copy link
Copy Markdown

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates subtitle clock synchronization to use the pipeline position (via IGstGenericPlayerPrivate::getPosition(m_context.pipeline)) instead of the video sink position, aligning subtitle PTS sync with the pipeline clock domain.

Changes:

  • Replace position query source from m_context.videoSink to m_context.pipeline using m_player.getPosition(...).
  • Simplify control flow by early-returning when position retrieval fails or subtitle source is missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 0.0% to 84.3%
Congratulations, your commit improved functions coverage from: 0.0% to 92.5%

@skywojciechowskim
skywojciechowskim merged commit fb575ee into release/v0.15.2 Jul 14, 2026
55 of 63 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
@skywojciechowskim
skywojciechowskim deleted the SubtitlesOutOfSync branch July 14, 2026 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants