Get the pipeline position instead of video sink position when syncing the subtitles#558
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
This PR updates subtitle clock synchronization to use the pipeline position (via IGstGenericPlayerPrivate::getPosition(m_context.pipeline)) instead of the video sink position, aligning subtitle PTS sync with the pipeline clock domain.
Changes:
- Replace position query source from
m_context.videoSinktom_context.pipelineusingm_player.getPosition(...). - Simplify control flow by early-returning when position retrieval fails or subtitle source is missing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage statistics of your commit: |
Summary: Get the pipeline position instead of video sink position when syncing the subtitles
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-21216