Add VBN/QA regression tests and FRIEND_TEST declarations for isSecureDbgSrvUnlocked#189
Draft
KTirumalaSrihari with Copilot wants to merge 2 commits into
Draft
Add VBN/QA regression tests and FRIEND_TEST declarations for isSecureDbgSrvUnlocked#189KTirumalaSrihari with Copilot wants to merge 2 commits into
KTirumalaSrihari with Copilot wants to merge 2 commits into
Conversation
…Unlocked Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on secure debug properties mechanism implementation
Add VBN/QA regression tests and FRIEND_TEST declarations for isSecureDbgSrvUnlocked
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-PROD build types (VBN, QA) had no unit test coverage for
isSecureDbgSrvUnlocked(), leaving the door open for silent behavior regressions. Additionally, allisSecureDbgSrvUnlocked_*tests were missingFRIEND_TESTdeclarations, preventing proper access to the private method under test.Changes
rfcMgr/gtest/gtest_main.cpp: Added two regression tests for non-PROD build types:isSecureDbgSrvUnlocked_vbn— VBN build →falseisSecureDbgSrvUnlocked_qa— QA build →falserfcMgr/rfc_xconf_handler.h: AddedFRIEND_TESTdeclarations for all sevenisSecureDbgSrvUnlocked_*test variants (dev,labsigned_true,prod,dType_prod,labsigned_DbgSrv_false,vbn,qa) to grant test access to the private method.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.