Skip to content

Add VBN/QA regression tests and FRIEND_TEST declarations for isSecureDbgSrvUnlocked#189

Draft
KTirumalaSrihari with Copilot wants to merge 2 commits into
RDKEMW-13335from
copilot/sub-pr-183
Draft

Add VBN/QA regression tests and FRIEND_TEST declarations for isSecureDbgSrvUnlocked#189
KTirumalaSrihari with Copilot wants to merge 2 commits into
RDKEMW-13335from
copilot/sub-pr-183

Conversation

Copilot AI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Non-PROD build types (VBN, QA) had no unit test coverage for isSecureDbgSrvUnlocked(), leaving the door open for silent behavior regressions. Additionally, all isSecureDbgSrvUnlocked_* tests were missing FRIEND_TEST declarations, preventing proper access to the private method under test.

Changes

  • rfcMgr/gtest/gtest_main.cpp: Added two regression tests for non-PROD build types:

    • isSecureDbgSrvUnlocked_vbn — VBN build → false
    • isSecureDbgSrvUnlocked_qa — QA build → false
  • rfcMgr/rfc_xconf_handler.h: Added FRIEND_TEST declarations for all seven isSecureDbgSrvUnlocked_* test variants (dev, labsigned_true, prod, dType_prod, labsigned_DbgSrv_false, vbn, qa) to grant test access to the private method.

// New tests follow the same pattern as existing PROD variants
TEST(rfcMgrTest, isSecureDbgSrvUnlocked_vbn) {
    writeToTr181storeFile("BUILD_TYPE", "vbn", "/tmp/device.properties", Plain);
    RuntimeFeatureControlProcessor *rfcObj = new RuntimeFeatureControlProcessor();
    EXPECT_EQ(rfcObj->isSecureDbgSrvUnlocked(), false);
    delete rfcObj;
}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…Unlocked

Co-authored-by: KTirumalaSrihari <102281309+KTirumalaSrihari@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on secure debug properties mechanism implementation Add VBN/QA regression tests and FRIEND_TEST declarations for isSecureDbgSrvUnlocked Mar 17, 2026
Copilot AI requested a review from KTirumalaSrihari March 17, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants