RDKEMW-15146 : Introduce mechanism to unlock secure debug properties - /opt/rfc.properties#183
Conversation
There was a problem hiding this comment.
Pull request overview
Introduces a gating mechanism to allow local RFC override (via the persistence rfc.properties file) only when “secure debug services” are unlocked, based on build type and device/test/labsigned conditions.
Changes:
- Adds RFC key support for a device type property and a device-type enum.
- Introduces
isSecureDbgSrvUnlocked()andgetDeviceTypeRFC()to decide whether secure debug services (and local RFC override) can be enabled. - Updates initialization and request processing to use the new unlock check when deciding to use the persistence RFC override file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
rfcMgr/rfc_xconf_handler.h |
Adds RFC key/constants and declarations for new secure-debug unlock helpers. |
rfcMgr/rfc_xconf_handler.cpp |
Implements unlock/device-type logic and gates persistence RFC override usage on the new unlock check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KTirumalaSrihari
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: to enable debug services, only if the build vairant is labSigned and device is test type or if the build type is Dev
Test Procedure: Flash the image and check for enabling secure debug services (override RFC properties from /etc/rfc.properties)
Risks: Low