Skip to content

RDKEMW-21453: LegacyNetworkAPIs logs are not printed under wpeframework logs #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karuna2git merged 9 commits into from
Jul 17, 2026
+10 −9
Merged

RDKEMW-21453: LegacyNetworkAPIs logs are not printed under wpeframework logs #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e6e51c
RDKEMW-21453: LegacyNetworkAPIs logs are not printed under wpeframewo…
gururaajar Jul 10, 2026
622dac9
Addressed compilation issue
gururaajar Jul 10, 2026
15333cd
Addressed the legacy prints missing issue
gururaajar Jul 10, 2026
f86dd50
Addressed the legacy prints missing issue
gururaajar Jul 10, 2026
7e7a6ad
Merge branch 'topic/RDKEMW-21453' of github.com:rdkcentral/networkman…
gururaajar Jul 13, 2026
62606f4
Merge branch 'topic/RDKEMW-21453' of github.com:rdkcentral/networkman…
gururaajar Jul 13, 2026
3999433
Merge branch 'topic/RDKEMW-21453' of github.com:rdkcentral/networkman…
gururaajar Jul 13, 2026
3edf110
Merge branch 'topic/RDKEMW-21453' of github.com:rdkcentral/networkman…
gururaajar Jul 13, 2026
dc474fa
Merge branch 'topic/RDKEMW-21453' of github.com:rdkcentral/networkman…
gururaajar Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions legacy/LegacyNetworkAPIs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ namespace WPEFramework

const string Network::Initialize(PluginHost::IShell* service )
{
NetworkManagerLogger::Init();
m_service = service;
m_service->AddRef();
string message{};
Expand Down
1 change: 1 addition & 0 deletions legacy/LegacyWiFiManagerAPIs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ namespace WPEFramework

const string WiFiManager::Initialize(PluginHost::IShell* service )
{
NetworkManagerLogger::Init();
m_service = service;
string message{};

Expand Down
11 changes: 5 additions & 6 deletions plugin/NetworkManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,6 @@ namespace WPEFramework
// Still running inside the main WPEFramework process - the child process will have now been spawned and registered if necessary
if (_networkManager != nullptr)
{

// Set the plugin log level
Exchange::INetworkManager::Logging _loglevel;
_networkManager->GetLogLevel(_loglevel);
NetworkManagerLogger::SetLevel(static_cast <NetworkManagerLogger::LogLevel>(_loglevel));

// Register Notifications
SYSLOG(Logging::Startup, (_T("Registering Notification to NetworkManager")));
_networkManager->Register(&_notification);
Expand All @@ -103,6 +97,11 @@ namespace WPEFramework
{
SYSLOG(Logging::Startup, (_T("Configuring successful")));
}

// Set the plugin log level
Exchange::INetworkManager::Logging _loglevel;
_networkManager->GetLogLevel(_loglevel);
NetworkManagerLogger::SetLevel(static_cast <NetworkManagerLogger::LogLevel>(_loglevel));
Comment thread
gururaajar marked this conversation as resolved.
// Register all custom JSON-RPC methods
SYSLOG(Logging::Startup, (_T("Registering JSONRPC Methods")));
RegisterAllMethods();
Expand Down
6 changes: 3 additions & 3 deletions plugin/NetworkManagerImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ namespace WPEFramework

/* Initialize Network Manager */
NetworkManagerLogger::Init();
NMLOG_INFO((_T("NWMgrPlugin Out-Of-Process Instantiation; SHA: " _T(EXPAND_AND_QUOTE(PLUGIN_BUILD_REFERENCE)))));
SYSLOG(::WPEFramework::Logging::Startup, (_T("NWMgrPlugin Out-Of-Process Instantiation; SHA: ") _T(EXPAND_AND_QUOTE(PLUGIN_BUILD_REFERENCE))));
m_processMonThread = std::thread(&NetworkManagerImplementation::processMonitor, this, NM_PROCESS_MONITOR_INTERVAL_SEC);
#if USE_TELEMETRY
// Initialize Telemetry T2 for NwMgrPlugin
Expand Down Expand Up @@ -142,12 +142,12 @@ namespace WPEFramework
Configuration config;
if(configLine.empty())
{
NMLOG_FATAL("config line : is empty !");
SYSLOG(::WPEFramework::Logging::Shutdown, (_T("config line is empty")));
return Core::ERROR_GENERAL;
Comment thread
gururaajar marked this conversation as resolved.
}
else
{
NMLOG_INFO("Loading the incoming configuration : %s", configLine.c_str());
SYSLOG(::WPEFramework::Logging::Startup, (_T("Loading incoming configuration")));
config.FromString(configLine);
}

Expand Down
Loading