RDKEMW-21453: LegacyNetworkAPIs logs are not printed under wpeframework logs#324
Open
gururaajar wants to merge 9 commits into
Open
RDKEMW-21453: LegacyNetworkAPIs logs are not printed under wpeframework logs#324gururaajar wants to merge 9 commits into
gururaajar wants to merge 9 commits into
Conversation
…rk logs Reason for Change: Fixed the legacy prints not printing issue Test Procedure: Check whether legacy prints are getting printed Priority: P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates logging behavior across the NetworkManager plugins to ensure key messages (notably legacy API logs and build reference/SHA) are emitted through the expected WPEFramework logging paths.
Changes:
- Switched select startup/configuration messages in
NetworkManagerImplementationfromNMLOG_*toSYSLOG(including build reference/SHA output). - Adjusted when the plugin log level is applied in
NetworkManagerinitialization (afterConfigure()). - Initialized
NetworkManagerLoggerin legacy Network/WiFi API plugins and added IPv6 public-IP telemetry labeling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugin/NetworkManagerImplementation.cpp | Uses SYSLOG for startup/config logs (including SHA) and adds IPv6 public IP telemetry key/logging. |
| plugin/NetworkManager.cpp | Moves log-level setup to occur after plugin configuration. |
| legacy/LegacyWiFiManagerAPIs.cpp | Initializes NetworkManagerLogger during legacy WiFi manager initialization. |
| legacy/LegacyNetworkAPIs.cpp | Initializes NetworkManagerLogger during legacy network API initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ager into topic/RDKEMW-21453
…ager into topic/RDKEMW-21453
…ager into topic/RDKEMW-21453
…ager into topic/RDKEMW-21453
…ager into topic/RDKEMW-21453
karuna2git
approved these changes
Jul 16, 2026
bpunnuru
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Fixed the legacy prints and SHA not printing issue
Test Procedure: Check whether legacy prints are getting printed along with the SHA of the tag.
Priority: P1