Skip to content

RDKB-65853: Fixing coverity issue #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
navyasher wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKB-65853: Fixing coverity issue #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/utils/quality_mgr/src/linkq.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,9 @@ vector_t linkq_t::run_algorithm(linkq_data_t data,
qmgr_invoke_score(mac,v.m_val[10].m_re,m_threshold);
}
}
m_window_samples.push_back(m_data_sample);
if (qmgr_is_batch_registered()) {
m_window_samples.push_back(m_data_sample);
}

if (update_alarm) {
alarm = (m_threshold_cross_counter >= ceil(0.8 * m_sampled));
Expand Down
1 change: 1 addition & 0 deletions source/webconfig/wifi_ovsdb_translator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,6 +1183,7 @@ webconfig_error_t webconfig_ovsdb_encode(webconfig_t *config,
wifi_util_dbg_print(WIFI_WEBCONFIG, "%s:%d: No change in config for subdoc type : %d\n",
__func__, __LINE__, type);
*str = NULL;
webconfig_data_free(&webconfig_ovsdb_data);
free_maclist_map(webconfig_ovsdb_data.u.decoded.num_radios, rdk_wifi_radio_state);
free(rdk_wifi_radio_state);
pthread_mutex_unlock(&webconfig_data_lock);
Expand Down
3 changes: 3 additions & 0 deletions source/webconfig/wifi_webconfig_em_ap_metrics_report.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ webconfig_error_t decode_em_ap_metrics_report_subdoc(webconfig_t *config, webcon
if (em_ap_report_arr == NULL || !cJSON_IsArray(em_ap_report_arr)) {
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: Invalid or missing EMAPMetricsReport\n",
__func__, __LINE__);
cJSON_Delete(json);
return webconfig_error_decode;
}

Expand All @@ -182,6 +183,7 @@ webconfig_error_t decode_em_ap_metrics_report_subdoc(webconfig_t *config, webcon
if (em_ap_report_obj == NULL) {
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: Invalid EMAPMetricsReport object at index %d\n",
__func__, __LINE__, i);
cJSON_Delete(json);
return webconfig_error_decode;
}

Expand All @@ -193,6 +195,7 @@ webconfig_error_t decode_em_ap_metrics_report_subdoc(webconfig_t *config, webcon
}
params->em_ap_metrics_report.radio_count = i;

cJSON_Delete(json);
return webconfig_error_none;
}
#endif
4 changes: 4 additions & 0 deletions source/webconfig/wifi_webconfig_harvester.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ webconfig_error_t decode_harvester_subdoc(webconfig_t *config, webconfig_subdoc_
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: object:%s not present, validation failed\n",
__func__, __LINE__, doc->objects[i].name);
wifi_util_error_print(WIFI_WEBCONFIG, "%s\n", (char *)data->u.encoded.raw);
cJSON_Delete(json);
return webconfig_error_invalid_subdoc;
}
}
Expand All @@ -129,16 +130,19 @@ webconfig_error_t decode_harvester_subdoc(webconfig_t *config, webconfig_subdoc_
if (obj == NULL) {
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: harvester object not present\n", __func__, __LINE__);
wifi_util_error_print(WIFI_WEBCONFIG, "%s\n", (char *)data->u.encoded.raw);
cJSON_Delete(json);
return webconfig_error_invalid_subdoc;
}

if (decode_harvester_object(obj, harvester) != webconfig_error_none) {
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: harvester object validation failed\n",
__func__, __LINE__);
wifi_util_error_print(WIFI_WEBCONFIG, "%s\n", (char *)data->u.encoded.raw);
cJSON_Delete(json);
return webconfig_error_decode;
}
wifi_util_info_print(WIFI_WEBCONFIG, "%s:%d: decode success\n", __func__, __LINE__);
cJSON_Delete(json);
return webconfig_error_none;
}

2 changes: 2 additions & 0 deletions source/webconfig/wifi_webconfig_link_report.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ webconfig_error_t decode_link_report_subdoc(webconfig_t *config, webconfig_subdo
if (decode_link_report(json, &data->u.decoded.qmgr_report) != webconfig_error_none) {
/* use qmgr_report */
wifi_util_error_print(WIFI_WEBCONFIG," %s:%d Failed in decoding link report\n",__func__,__LINE__);
cJSON_Delete(json);
return webconfig_error_decode;
}
cJSON_Delete(json);
return webconfig_error_none;
}
12 changes: 10 additions & 2 deletions source/webconfig/wifi_webconfig_multivap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,16 @@ webconfig_error_t decode_multivap_subdoc(webconfig_t *config, webconfig_subdoc_d
radio_index, vap_array_index);
continue;
}
wifi_util_dbg_print(WIFI_WEBCONFIG, "%s:%d: radio index: %d , vap name: %s\n%s\n", __func__,
__LINE__, radio_index, name, cJSON_Print(obj_vap));
str = cJSON_Print(obj_vap);
if (str != NULL) {
json_param_obscure(str, "Passphrase");
json_param_obscure(str, "RadiusSecret");
json_param_obscure(str, "SecondaryRadiusSecret");
json_param_obscure(str, "DasSecret");
}
wifi_util_dbg_print(WIFI_WEBCONFIG, "%s:%d: radio index: %d , vap name: %s\n%s\n",
__func__, __LINE__, radio_index, name, (str != NULL) ? str : "");
cJSON_free(str);
vap_info = &params->radios[radio_index].vaps.vap_map.vap_array[vap_array_index];
rdk_vap_info = &params->radios[radio_index].vaps.rdk_vap_array[vap_array_index];
memset(vap_info, 0, sizeof(wifi_vap_info_t));
Expand Down
Loading