RDKB-65853: Fixing coverity issue#1266
Open
navyasher wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes multiple Coverity findings primarily related to memory/resource handling in webconfig decode/encode paths and quality manager sample buffering.
Changes:
- Prevent leaks by explicitly freeing
cJSONobjects in several subdoc decode functions. - Fix a
cJSON_Print()debug-string leak in multivap decode logic. - Avoid accumulating link quality window samples when no batch consumer is registered.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| source/webconfig/wifi_webconfig_multivap.c | Frees cJSON_Print() output used for per-VAP debug logging. |
| source/webconfig/wifi_webconfig_link_report.c | Deletes parsed cJSON on both success and failure during decode. |
| source/webconfig/wifi_webconfig_harvester.c | Deletes parsed cJSON on early-return error paths and on success. |
| source/webconfig/wifi_webconfig_em_ap_metrics_report.c | Deletes parsed cJSON on validation/decode failures and on success. |
| source/webconfig/wifi_ovsdb_translator.c | Attempts to free encoded raw data on “no config change” early return (but currently has an argument-type bug). |
| source/utils/quality_mgr/src/linkq.cpp | Only buffers window samples when batch reporting is registered. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Fixing coverity issues. Test Procedure: Build should be successful and the regression test should also succeed Risks: Low Priority: P1 Signed-off-by: Navya_Sheregar@comcast.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com