Repository navigation
[PR] fix: budget with only targetTimeoutMs no longer drops the whole compress block (#7100) - #7109
ranxianglei wants to merge 2 commits into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10730-pr.7109.33a4c15This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr7109.tgz
npm install -g packageInstall instructions are refreshed on each push. |
…ess block (#7100) A lone targetTimeoutMs (e.g. 90000) without totalTimeoutMs was rejected because the default total (50000) was smaller — the whole compress section was silently dropped (no log, no CLI validation, /__bili/config returned a bare {invalid:true}). Root cause: parseBudget validated targetTimeoutMs against the default total (50000) instead of the global cap (600000). When totalTimeoutMs was absent, it defaulted to 50000 first, then targetTimeoutMs was checked against that default — so any target > 50000 threw. Fix: - parseBudget now validates targetTimeoutMs against the global cap (600000) first. When totalTimeoutMs is absent, it defaults to target × targetCount (floored at the 50000 default, capped at 600000) so each sequential target gets its full window. Only an EXPLICIT total smaller than the target is a genuine contradiction (throws a specific message naming both values). - /__bili/config now carries the invalid reason (error.message) so the dropped block is observable on demand. - The compress-config rejection is recorded in config.ts (before configureLogger, so its own warn never reached the file) and logged once after the logger is live in createEngineContext. - /__bili/status now carries a compressConfigError field (additive) so the dropped block is visible in the status endpoint. - Docs (en/zh/ja): documented the default total derivation when totalTimeoutMs is omitted. Closes #7100
87e1164 to
d79e4f2
Compare
… is removed on reload (#7100) The module-level pendingCompressValidationError was only cleared when externalSummary was present AND valid. A config reload that removes the externalSummary field (or the whole compress section) left the stale rejection visible in /__bili/status. Reset it at the top of parseCompressSettings so only a freshly-seen invalid block re-arms it. Adds a regression test.
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) This is my own completed PR ( Verification
Drive-by fix (commit
|
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Follow-up — CI after my push is green: all 8 workflow runs for head One note: master moved again while I was working ( |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Confirming the work is done (details in my two replies above): PR #7109 verified correct — code traced, 49/49 tests, typecheck clean, CI green for head |
(ai: vllm-qwen/qwen3.8-27b) Live check state (re-verified this run): Diagnosis: the failing file is What I did this run:
No commits pushed. The PR is blocked only on the master-level test fix landing in ci-fixes; once it does, this branch merges ci-fixes and turns green. 八问
收工判定: 本 PR 侧无代码可修——CI 红为继承性 master 级失败,已上报 #4599 待哨兵收敛到 ci-fixes;ci-fixes 修复落地后本分支 merge ci-fixes 即转绿。 |
[ework] CI fix verified green ✓ |
What
A lone
targetTimeoutMs(e.g. 90000) withouttotalTimeoutMswas rejected because the default total (50000) was smaller — the wholecompresssection was silently dropped (no log, no CLI validation, /__bili/config returned a bare{invalid:true}).Root cause
parseBudgetvalidatedtargetTimeoutMsagainst the default total (50000) instead of the global cap (600000). WhentotalTimeoutMswas absent, it defaulted to 50000 first, thentargetTimeoutMswas checked against that default — so any target > 50000 threw.Fix
targetTimeoutMsagainst the global cap (600000) first. WhentotalTimeoutMsis absent, it defaults totarget × targetCount(floored at the 50000 default, capped at 600000) so each sequential target gets its full window. Only an EXPLICIT total smaller than the target is a genuine contradiction (throws a specific message naming both values).error.message) so the dropped block is observable on demand.config.ts(beforeconfigureLogger, so its own warn never reached the file) and logged once after the logger is live increateEngineContext.compressConfigErrorfield (additive) so the dropped block is visible in the status endpoint.totalTimeoutMsis omitted.Behavior changes
targetTimeoutMs: 90000(nototalTimeoutMs) was rejected before; now it works withtotalTimeoutMsderived to 90000 (1 target) or 180000 (2 targets)./__bili/configinvalid sentinel now includes areasonfield (additive)./__bili/statusnow includes acompressConfigErrorfield (additive, null when no error).Tests
Closes #7100