Repository navigation
Conversation
Use split image sidecars instead of expanding the whole carrier under every image ref; preserve unsplit and tool-result image groups. Fixes ranxianglei#6851
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Dedup: not a duplicate. Searched open+closed issues/PRs for the same symptom/mechanism (split Responses image refs, recovery index, spill cross-product): #6854 is the only open PR against #6851. The related items the PR itself lists are distinct failure domains and are all closed or out of scope (#4770 outbound reconstruction, #5492 OpenAI assistant/tool sidecars, #6089 truncated files, #6701 escaped JSON markers). Review verdict: mergeable (可合), once CI lands green. I did not take the PR's claims on faith — I reproduced both halves locally on the exact head
Recommended labels for this PR (not applied — source PR labels are owner/automation territory): 八问(中文结论)
判定:可合(CI 剩余 6 个排队项转绿后由 owner 合并;合并是人工操作)。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) CI follow-up (live-checked via mirror cache): all 30 checks now complete, 0 failed, 0 pending — the six queued guards (docs-sync, docs-coverage, config-surface-guard, unused-exports, mysql-contract, pi-subagents-guard) all landed green. The PR is fully green and ready for a human merge: #6854 |
Problem
Fixes #6851.
A multi-image Responses user item is split into separate core messages and refs. Each image core carries its own pixels but also retains the whole original wire item. The recovery index walks that whole item, so every image ref restores all its sibling images.
This produces both incorrect retrieval and multiplicative disk work. Two screenshots are restored together even when only one ref was requested; a remote-only image ref can incorrectly return a neighboring inline image. Twenty image parts create 400 recovery files.
Changes
When a Responses core has the parser's existing
imagePartflag, recover its ownimageBase64sidecar only. A split URL-only occurrence has no carried bytes and remains unavailable for recovery. Unsplit carriers and tool-result groups still recover all their images.Repeated identical images retain separate occurrence refs. The change is confined to the host recovery index; kernel identity, outbound rendering, image encoding, file naming, and expiry behavior are unchanged.
Validation
Tested against parent/master
2e3cfc973b8620b1f7bc8a415ddcbd31e7f4aaee(0.1.215).Unchanged master: four new regressions fail and sixteen controls pass. The tests use the real Responses parser, ref assignment, recovery file writer, and decompress tool path with valid red/blue PNGs.
Candidate: 76 focused tests passed.
The controls include image recovery across all four wires, incomplete-spill repair, original-image recovery, Responses partial-fold rendering, media shedding, and real local HTTP proxy/plugin paths. The fixtures and HTTP upstreams are hermetic.
Also passed:
node node_modules/typescript/bin/tsc --noEmit --project tsconfig.jsonnpm run buildnode scripts/check-test-import-graph.mjsgit diff --checkThe live Codex four-phase E2E has not been run.
E2E_CHECK=1confirms the distribution and CLI, but its configuredhttp://127.0.0.1:8199/v1/modelsupstream is unreachable.Related work checked
#4770 addresses outbound Responses reconstruction in
responses-tool-output.ts; this patch fixes the separate recovery-index consumer. Open #5492 archives missing OpenAI assistant/tool image sidecars and does not change Responses split-image ownership. #6089 repairs truncated image files, while #6701 recognizes escaped JSON image markers.