Repository navigation
[PR] fix(incremental): keep large seed envelopes on the incremental lane - #6681
ranxianglei merged 1 commit into
Conversation
(ai: vllm-qwen/qwen3.8-27b) Review — fix(incremental): keep large seed envelopes on the incremental lane Independent review: I re-derived the bug from the code (not from the description), verified the fix's safety argument, and ran the targeted suites locally. What I verified
Minor note (not a blocker): for a large (>64 MiB) ordinary marked request the body is now parsed twice (shape check + pipeline) where it was parsed once before. That's a rare path (marked incremental turns over 64 MiB that are ordinary) and the body is bounded by the 5 GiB receive budget, so it's a negligible CPU cost — not a behavior regression. 结构化八问(中文,供人工 reviewer):
判定: 可合(本地定向测试 + typecheck 全绿;全量 CI 仍 queued,以远程 CI 为准)。 |
(ai: vllm-qwen/qwen3.8-27b) Status update (full review is the comment above):
|
|
Superseded by #6765 (merged to master as f24173e). Your commit baee51f is in master verbatim — same content, same authorship, only the object ID changed (the batch used a real Thanks for the fix — it is live in master from f24173e onward. (Your source branch was deleted after the merge, which is why GitHub could not detect the ancestor relationship either — tip baee51f is an ancestor of master.) |
|
Superseded by #6765 (merged to master as f24173e). Your commit baee51f is in master verbatim — same content, same authorship, only the object ID changed (real git merge, no rebase/cherry-pick rewrite). Your source branch was deleted after the merge, which is why GitHub could not detect the ancestor relationship — tip baee51f is an ancestor of master. Thanks! |
(ai: claude-opus-5-5)
incrementalTurnBodyShaperefuses any body over 64 MiB. The client-side check it mirrors (incrementalEnvelopeConversationId) has no size limit, so a marked turn whose seed envelope crosses 64 MiB is classified as lane traffic by the client but as an ordinary request by the server. The server then replays the envelope through the normal pipeline to the upstream provider, which isn't a valid model request, and the turn fails. Long sessions reach this on their first (seed) turn.The receive-size budget is already enforced by
readBody(limitsReceiveBytes, 5 GiB default, 413 on overflow) before the shape check runs, so the second limit only adds a gap between 64 MiB and that budget. This PR removes it.Test:
tests/incremental-large-body.test.tscovers a >64 MiB envelope (must classify as lane traffic) and a >64 MiB ordinary marked request (must stay ordinary). The first case fails on master and passes with the change.tests/incremental-lane.test.tsandtests/opencode-incremental.test.tspass, and so doesnpm run typecheck. Full CI was not run locally.