Repository navigation
[PR] fix(incremental): keep message arrival timestamps across a crash before the SQLite save - #6818
mariopasquali wants to merge 5 commits into
Conversation
…pled verification
40ca070 to
7688d22
Compare
(ai: vllm-qwen/qwen3.8-27b) Merge conflict resolved — PR rebased onto current master, force-pushed. What was done this run:
七问:
判定:冲突已解,PR 回到 blocked(等人工合并),收工。 |
[bot] 🏷 Duplicate screening: Not a duplicate. No other open/closed issue or PR targets "a crash between the incremental-lane ack and the debounced SQLite save loses the kernel's in-memory arrival timestamps." Adjacent-but-different: #6681 (large seed envelopes), #5745 (repeated-message identities, closed), #4881 (forward-fail canonical rollback), #6716 (receipt-timestamp perf), #6247 (extension timestamps across archive restore) — each is a different symptom/mechanism. Merge status (verified live): The head ( Local verification (on the PR head):
结构化八问(审核结论)
判定:方向正确(修根因——持久化顺序,不是掩症状),代码与测试扎实(71/71 真测试,含并发/回滚/预算/驱逐矩阵),无回归、无缓存破坏。PR 已 rebase 到当前 master、无冲突、CI 无失败(7 项在跑)。可合(等 CI 全绿 + 人工过目)。 |
[ework] CI fix verified green ✓ |
…#6818) The architecture-docs CI lane (tools/check-architecture-docs.mjs) requires every src/ module to be listed in reference/architecture.md. PR #6818 added src/incremental-first-seen.ts but only updated the pi.ts row, so the new module's entry was missing and the lane failed. Add the row in alphabetical order (before incremental-lane.ts).
….md (#6818) The post-#6592/#6880 re-merge (2d53c13) was based on e45ad01, which predates the 25a89b1 fix that listed src/incremental-first-seen.ts, so the entry was lost and the architecture-docs CI lane failed on 6d2e2a1. Re-add the row (alphabetical, before incremental-lane.ts). Guard passes locally.
(ai: claude-opus-5-5)
On the incremental lane the server acknowledges a turn (
appliedSeq) before the debounced SQLite save. The kernel's arrival timestamps for the new messages exist only in memory until that save. If the process stops in between, the plugin never resends those messages, and after the restart they get a new timestamp from the reseed instead of their real arrival time.What this PR does:
Tests: new
tests/incremental-first-seen.test.ts, plus new cases intests/opencode-rolling-cache-marks.test.tsandtests/storage-batched-verification.test.ts. 71/71 pass in those four files (includingtests/incremental-lane.test.ts). On master, 4 of the 5 new verification tests fail; the other new tests need the new module. Typecheck and the unused-export check pass. Full suite: 12,267 tests, 12,191 pass, 74 skipped, 1 fail (tests/wire-exit-matrix.test.tsOpenAI SSE abort timing; it passes 3/3 when run alone, and it doesn't touch the incremental lane). On our machine,tests/issue4612-gc-online-guard.test.tshangs inside the full suite on master too; it passes when run alone on both.