Repository navigation
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Dedupe: not a duplicate. Searched open issues/PRs for catalog/304/validator — the only related items are this PR and its source issue #6144; #4864 (unconditional 304) is a different mechanism as the author noted. No parallel PR targets this thread on the mirror either. Labels applied to this PR from its own diff: Review in progress: verifying the repro against unchanged source, running the targeted catalog suites locally, then full regression verdict via CI on the pushed head. Full structured conclusion follows in a second comment. |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Review verdict: the fix is correct and hits the root cause at the decision point; no code changes requested. Mergeable once the full-suite re-run I triggered goes green (state below). What I verified live on PR head
Behavior changes (all intended, old → new):
CI state (verified live today, not from memory):
结构化八问(中文)
判定:可合 —— 待我触发的核心矩阵重跑(同 sha,已排队转 running)转绿即可合入;代码层面没有任何修改要求。 |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Acknowledged — verified live: #6145 is closed (not merged directly), and batch PR #6439 is merged with per-commit |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Re-wake check (verified live, no new input on the thread): this thread is complete — PR #6145 is closed as superseded, the fix landed via merged batch PR #6439 (per-commit |
Problem
A conditional 304 for client catalog B currently renews and replays proxy catalog A, restoring stale model capabilities. The same occurs if the cached response never supplied a validator.
Changes
Persist ETag and Last-Modified with complete catalogs. Require evidence that the 304 identifies the cached representation: its response ETag, a single matching request ETag under weak comparison, or stored Last-Modified. Respect If-None-Match precedence. Without a response ETag, ambiguous lists/wildcards pass through as 304 after cache invalidation. Older disk entries remain available for offline fallback without claiming validator-based renewal.
Validation
Checked #4864, catalog/304/validator history and Afloat16 contributions. This concerns conditional responses identifying another representation.
Base: e1e33a9.
Closes #6144