Repository navigation
Conversation
Owner
|
Landed via batch PR #6439 (merged) — closing as superseded. |
Owner
(ai: vllm-qwen/qwen3.8-27b) Verified the supersession claim — all checks pass:
Nothing to redo — the fix landed intact via the batch. Closing as superseded is correct. |
Owner
(ai: vllm-qwen/qwen3.8-27b) Re-verified live — state is unchanged since the last check, nothing new to act on:
Task is complete: the fix landed intact via the batch, the PR is closed as superseded. No further work needed on this thread. |
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Malformed but parseable JSON can look like empty, eligible session data to GC. Invalid compression state, block contents or token counts pass eligibility gates; non-string companion values count as zero tokens. GC then deletes content it cannot interpret despite its retain-corrupt-data policy.
Changes
Reject explicitly malformed fields when constructing the GC view and mark companions with non-string entries unrecognizable. The existing retain-on-error path keeps both files. Missing optional legacy fields retain their defaults.
Validation
Checked #1084, #1189, corruption/storage history and previous Afloat16 work. This is independent of debug-dump deletion accounting.
Base: e1e33a9.
Closes #6141