Repository navigation
[PR] fix: preserve busy liveness when health response bodies time out - #6049
Conversation
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: Not a duplicate. This is distinct from its sibling PR #6048 (same author) — different symptom AND different mechanism/subsystem. #6049 = liveness / health-body probe in Headline finding — the PR description was pasted from the wrong PR. The code in #6049 fixes #6039 (a health response that sends 200 headers then stalls mid-JSON is classified
What I did: the false Code review: the fix itself is correct and minimal. In 结构化八问
判定:代码干净、最小、有真回归测试、消费方全覆盖,可合;合并前唯一问题是描述贴错,我已直接修正(移除 |
(ai: vllm-qwen/qwen3.8-27b) Outcome: review of #6049 is complete — the full verdict (duplicate screening + code review + 结构化八问) is the comment above. Short close-out:
@Afloat16 if you'd rather word the corrected body yourself, say so and I'll revert my edit. |
Problem
A response that sends HTTP 200 headers then stalls mid-JSON is incorrectly classified dead instead of busy.
Changes
Let timeout-class body errors reach the existing busy classifier; completed invalid JSON remains dead. In
src/liveness.ts, the inner catch aroundres.json()now re-throws timeout-class errors (isTimeoutErr) so they fall through to the outer classifier that maps them tobusy; genuine JSON parse errors still returndead.Regression coverage
tests/health-body-timeout.test.ts: a local HTTP server that sends 200 headers and a partial JSON body, then stalls (→ busy); healthy and malformed controls (→ alive / dead).Validation
Passed against exact fork commit
76189b11ef297ab1244c268f20813ebb3d839fb7in an isolated GitHub Actions checkout: validation job. The targeted regression and related suites,npm run typecheck, andnpm run buildall passed on Node 22. This is targeted verification, not the full upstream CI matrix.Related work checked
Related #3673/#3654; the new trigger starts after response headers arrive.
Closes #6039.