Repository navigation
[PR] fix: retain failed dump deletions in GC byte accounting - #6050
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复,但本 PR 与同作者另两个 PR 存在描述串档。#6050 的实际 diff 只对应 issue #6040(dump-GC 字节记账);#6038(深嵌套媒体遍历)已有独立 PR #6048, #6039(健康检查超时分类)已有独立 PR #6049。本 PR 正文误贴了 #6038 的文案, 标签:本环境当前无法调用打标接口,未能给本 PR 打标签——如实报告,不静默跳过。建议补: CI 状态(约 15:15 UTC):head FindingsCode — correct and complete for #6040. The diff touches only
This fixes exactly the reported defect: previously a locked/unlinkable file was counted as freed while still on disk, so retained dumps could exceed Packaging — metadata cross-contamination (no code impact). Three problems, all in the description:
I've already repaired the description using your own accurate #6040 wording (same commit 结构化八问
判定:代码对 #6040 正确、最小、且有回归测试钉住,可合;合并前须满足 ① 上游 CI 矩阵转绿(现 queued)、② 描述更正为仅 Closes #6040(我已代改,请作者确认)。#6038 / #6039 由各自 PR(#6048 / #6049)处理,本 PR 不应也不需覆盖它们。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1149-master.c8dce58 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Version
billion-context 0.1.213, master
4be21b08ed3da8b69d1800a10a9c0b9c5a707f71.Problem
Retention subtracts bytes even when unlink fails, allowing retained dumps to exceed the configured budget.
Proposed correction
Keep failed aged deletions among survivors and charge their bytes until deletion actually succeeds.
Regression coverage
Deterministic EPERM unlink failure under both byte-only and combined age/byte policies; removable newer files still bring retained bytes under the cap.
Validation
Passed against exact fork commit
1b43b991f3673d1acb552278088701e0e831e69cin an isolated GitHub Actions checkout. The targeted regression and related suites,npm run typecheck, andnpm run buildall passed on Node 22. This is targeted verification, not the full upstream CI matrix.Related work checked
Checked gcDebugDir/state-gc history including #277 and #2575.
Closes #6040.