Repository navigation
[PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) - #6024
Conversation
(ai: vllm-qwen/qwen3.8-27b) Dedupe: no duplicate. Searched open+closed issues/PRs for the same symptom/mechanism: #6024 is the only open fix targeting #6021. Related family items are all closed and orthogonal in mechanism: #5752 (request-image handle classifier — its note that the placeholder is "deliberately unclassified" is exactly what produced this residual), #5150 (expected-rebase drift accounting), #3644/#3588 (fold-anchoring doctrine / substrate-destroyed verdicts). Same lane (#5173 anchor family), different facet: this one classifies the placeholder side of the offload event. Labels: mirror #6026 → Review in progress: branch checked out at |
…the offload placeholder A [text, image] original keeps its prose before the '[' bracket, so the marker can sit mid-text; pin that the documented substring match classifies it (coverage folded in from the parallel analysis in ranxianglei#6027).
(ai: vllm-qwen/qwen3.8-27b) Review complete — verdict: mergeable, subject to two owner-side items at the end. Evidence below; 八问 in Chinese at the bottom.
Independent audit of #6021 (verified at the PR head, not taken on trust from either description):
Regression review (existing behaviors touched): three behavior changes, all intended and gated to pluginAgent==="dsh": (1) placeholder messages lose Rule-3 anchor eligibility — the fix itself; (2) placeholder ids enter the expected-rebase ledger on first sight (their later retirement is accounted, not alarmed); (3) the stored-row backfill pre-filter screens two new markers (lockstep test updated 12→14). No unintended regressions found: no other path reads the new path string or markers; benign-FP blast radius = a dsh user literally typing the marker text loses anchor eligibility for that one message (the module's documented benign-FP doctrine). Neighbor suites (durable-tool-identity, dsh skill/mcp/workspace/runtime catalogs, fold-drift, fold-reconcile): 106/106 green locally. Code & test quality: meets the external bar — no refactor needed. The classifier follows every sibling convention (role gate first per #2766; includes-not-prefix documented with the splice rationale; appended LAST in both chains so order among one-shots is provably irrelevant). The role-gate table row (tests/issue2766-durable-role-gate.test.ts:34) keeps assistant-echo discipline in lockstep with every carrier family. Diff: 4 files, every line on-purpose. Verification state (live as of writing):
Non-blocking: the 🔶 decision request already on #6021 (offloaded cells re-ingest with fresh ref/ts → ts/ref-based freshness sees stale-as-new; option A content-addressing vs B continuity) is a separate pending-owner item and does not affect this PR. Also flagging for your severity re-judgment when closing the duplicate: the #6027 thread's reviewer rated this p1; I kept p2 here because the trigger surface is narrow (dsh lane + image + compaction + the placeholder ending up as the last user message) and the harm is a lossy fold + a wrong-topic answer for one turn, immediately recoverable by restating the question — not permanent data loss. Your call either way. 八问(结构化审核结论)
判定:可合并 —— 前提:① owner 将 #6027 以 duplicate of #6024 关闭;② c855d6f 上的新一轮 CI 全绿(静态守卫已绿,测试车道行进中)。合并操作留给你(agent 不合并 PR)。 |
…fload placeholder (folded in from parallel PR ranxianglei#6027) The unit rows pin that the classifier resolves; this file pins the actual failure mode of ranxianglei#6021 through applyCompression with the REAL dsh registry: a fold covering the offloaded tail must keep the live request visible (the stale placeholder loses Rule-3 last-user anchor eligibility), and a placeholder ahead of the live request still folds normally (no bloat).
Fixes #6021
What broke: after a compaction, DSH swaps the image in history for a placeholder line ("[image omitted to fit request image limits; ...]") plus the original user words. Nothing classified it, so lastUserAnchor() pinned the placeholder as the current question and the model answered a two-day-old screenshot.
What changed: new dshImageOffloadPlaceholderPath classifier returning oneshot/image-offload-placeholder, wired into both registries (slot exclusion and drift accounting), plus both markers in dshCarrierRawMarkers. The text-only-route sibling marker shares the same family. A placeholder still never classifies as a live handle.
How verified: the three suites covering this area pass 34/34 (anchor geometry keeps the live request pinned, classifier units, marker lockstep, role gate). Neighbor suites match pristine master exactly, and the touched files typecheck clean.