Skip to content

[PR] Revert "[PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021)" - #6060

Merged
ranxianglei merged 1 commit into
masterfrom
revert-6027-2026-11-09_dsh-image-offload-placeholder-anchor
Nov 9, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
revert-6027-2026-11-09_dsh-image-offload-placeholder-anchor

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Reverts #6027

@ranxianglei
ranxianglei merged commit abd1e8a into master Nov 9, 2026
22 checks passed
@ranxianglei ranxianglei changed the title Revert "[PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021)" [PR] Revert "[PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021)" Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: revert-6027-2026-11-09_dsh-image-offload-placeholder-anchor (7d5f42e)

Latest build — install this exact version

npm install -g billion-context@0.0.8836-pr.6060.3665b86

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
7d5f42e billion-context@0.0.8836-pr.6060.3665b86 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr6060.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重:不重复 —— #6060 本身就是一个去重动作。它撤销了与 #6024(sx4im)内容重叠的 #6027(owner 本人);master 上针对 #6021 的修复最终只保留一份(#6024),无残留重复、无并行 PR 互相踩。

标签:dsh / scope/kernel / p3(本环境 e-work shim 未实现 labels API,我这边代打不了;建议 owner 手动补)。

结论(先说人话)

这是 owner 用 GitHub「Revert」按钮对 #6027 发起的回退 PR,已合入 master(revert commit 7d5f42e,merge abd1e8a)。它不是修一个新 bug,而是撤销一个重复修复:

为什么这样是对的(审核判断)

结构化八问

  1. 是什么问题:owner 对 [PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021) #6027 的回退 PR([PR] Revert "[PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021)" #6060)—— 不是新缺陷,是撤销一个重复修复。
  2. 什么原因导致:[Bug][dsh] image-offload placeholder text hijacks the last-user anchor: model treats a two-day-old screenshot as the cur | [Bug][dsh] image-offload 占位文本抢走 last-user 锚点:模型把两天前的旧截屏当成当前提问(bili 0.1.213 / DSH 0.2.2-rc.1) #6021 被 [PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) #6024 / [PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021) #6027 两个并行 PR 同时修、内容重叠;为收敛到单一实现,回退其中一份(本人的 [PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021) #6027)、保留 [PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) #6024。
  3. 影响范围与严重程度:仅 dsh 车道的 image-offload 分类路径;用户侧无可感知行为变化(净行为不变,由 [PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) #6024 承接等价修复)。严重度 p3(纯去重清理,不改语义)。
  4. 怎么修的:策略是「去重收敛」—— 干净 git revert 撤掉 [PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021) #6027 的分类器+测试+接线,由 [PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) #6024 补回其自身版本;master 最终只剩一套一致的 classifier。
  5. 是否有回归:审过 last-user anchor 锚定、expected-rebase 漂移记账、one-shot carrier 三处注册表的既有行为 —— 均保持(由 [PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) #6024 承接,与回退前一致)。高危模式逐项过:无语义漂移、无 fail-fast→吞错、无阈值/时序/输出格式变化;master tip CI 3/3 绿佐证无编译/测试回归。
  6. 是否破坏缓存:不涉及。分类器只改消息身份归类(anchor eligibility / drift accounting),不动前缀缓存字节、重试或去重键。
  7. 是否改了设计方向:不涉及。仍是 KDD release v0.1.2 #9 evidence-permitlist 下 dsh 车道的 one-shot carrier 分类,方向未变,仅实现来源从 [PR] fix: classify the dsh image-offload placeholder so it cannot steal the last-user anchor (#6021) #6027 换为 [PR] fix: classify the dsh image-offload placeholder as a one-shot carrier (#6021) #6024。
  8. 是否引入了新的配置:不涉及。无新增 env / config / 默认值。

收工判定:#6060 是一次正确且安全的去重回退,无待办、无需我动手(我亦不合 PR)。#6021 在 master 上仍由 #6024 修复且 CI 绿,建议 owner 验收后自行关闭对应条目即可。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷

已处理完毕(完整审核见上一条)。结论一句话:#6060 = owner 对 #6027 的回退,已合入 master,本质是「去重」——#6021(dsh image-offload 占位文本抢走 last-user 锚点 → 模型把两天前的旧截屏当当前提问、整轮答非所问;bili 0.1.213 / DSH 0.2.2-rc.1)被 #6024(sx4im,外部)与 #6027(本人)两个并行 PR 同时修,owner 回退本人的 #6027、保留外部的 #6024,收敛成单一实现。

已逐处核实 origin/master(44463017,tip CI 3/3 success):offload 分类器 dshImageOffloadPlaceholderPath(src/durable-message-guards.ts:331)及其三处接线(slot-exclusion :375 / drift-accounting :434 / raw-markers :457–458)+ 测试文件 tests/issue6021-image-offload-anchor.test.ts 全部保留,与 #6027 声称的覆盖范围一致甚至更完整。故 #6021 在 master 上仍是已修复状态,净行为不变,回退没有让 bug 复发。

无待办、无需我动手(我亦不合 PR)。标签建议 dsh / scope/kernel / p3(本环境 e-work shim 未实现 labels API,我代打不了,建议 owner 手动补)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant